From: kbuild test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com, tj@kernel.org,
Roman Gushchin <guro@fb.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v2 bpf-next 05/14] bpf: extend bpf_prog_array to store pointers to the cgroup storage
Date: Fri, 6 Jul 2018 15:50:07 +0800 [thread overview]
Message-ID: <201807061432.Y2kh3R8Y%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180705205139.3462-6-guro@fb.com>
[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]
Hi Roman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/bpf-cgroup-local-storage/20180706-055938
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-u0-07061335 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media//rc/bpf-lirc.c: In function 'lirc_bpf_free':
>> drivers/media//rc/bpf-lirc.c:203:44: error: 'struct bpf_prog_array' has no member named 'progs'
progs = rcu_dereference(rcdev->raw->progs)->progs;
^
vim +203 drivers/media//rc/bpf-lirc.c
f4364dcf Sean Young 2018-05-27 191
f4364dcf Sean Young 2018-05-27 192 /*
f4364dcf Sean Young 2018-05-27 193 * This should be called once the rc thread has been stopped, so there can be
f4364dcf Sean Young 2018-05-27 194 * no concurrent bpf execution.
f4364dcf Sean Young 2018-05-27 195 */
f4364dcf Sean Young 2018-05-27 196 void lirc_bpf_free(struct rc_dev *rcdev)
f4364dcf Sean Young 2018-05-27 197 {
f4364dcf Sean Young 2018-05-27 198 struct bpf_prog **progs;
f4364dcf Sean Young 2018-05-27 199
f4364dcf Sean Young 2018-05-27 200 if (!rcdev->raw->progs)
f4364dcf Sean Young 2018-05-27 201 return;
f4364dcf Sean Young 2018-05-27 202
f4364dcf Sean Young 2018-05-27 @203 progs = rcu_dereference(rcdev->raw->progs)->progs;
f4364dcf Sean Young 2018-05-27 204 while (*progs)
f4364dcf Sean Young 2018-05-27 205 bpf_prog_put(*progs++);
f4364dcf Sean Young 2018-05-27 206
f4364dcf Sean Young 2018-05-27 207 bpf_prog_array_free(rcdev->raw->progs);
f4364dcf Sean Young 2018-05-27 208 }
f4364dcf Sean Young 2018-05-27 209
:::::: The code at line 203 was first introduced by commit
:::::: f4364dcfc86df7c1ca47b256eaf6b6d0cdd0d936 media: rc: introduce BPF_PROG_LIRC_MODE2
:::::: TO: Sean Young <sean@mess.org>
:::::: CC: Daniel Borkmann <daniel@iogearbox.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35548 bytes --]
next prev parent reply other threads:[~2018-07-06 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 20:51 [PATCH v2 bpf-next 00/14] bpf: cgroup local storage Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 01/14] bpf: add ability to charge bpf maps memory dynamically Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 02/14] bpf: introduce cgroup storage maps Roman Gushchin
2018-07-06 14:42 ` kbuild test robot
2018-07-06 21:52 ` Roman Gushchin
2018-07-07 22:35 ` Alexei Starovoitov
2018-07-09 8:37 ` Daniel Borkmann
2018-07-09 18:53 ` Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 03/14] bpf: pass a pointer to a cgroup storage using pcpu variable Roman Gushchin
2018-07-06 7:50 ` kbuild test robot
2018-07-06 9:25 ` kbuild test robot
2018-07-05 20:51 ` [PATCH v2 bpf-next 04/14] bpf: allocate cgroup storage entries on attaching bpf programs Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 05/14] bpf: extend bpf_prog_array to store pointers to the cgroup storage Roman Gushchin
2018-07-06 7:50 ` kbuild test robot [this message]
2018-07-05 20:51 ` [PATCH v2 bpf-next 06/14] bpf/verifier: introduce BPF_PTR_TO_MAP_VALUE Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 07/14] bpf: don't allow create maps of cgroup local storages Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 08/14] bpf: introduce the bpf_get_local_storage() helper function Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 09/14] bpf: sync bpf.h to tools/ Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 10/14] bpftool: add support for CGROUP_STORAGE maps Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 11/14] bpf/test_run: support cgroup local storage Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 12/14] selftests/bpf: add verifier cgroup storage tests Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 13/14] selftests/bpf: add a cgroup storage test Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 14/14] samples/bpf: extend test_cgrp2_attach2 test to use cgroup storage Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807061432.Y2kh3R8Y%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®