From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66AFC6778F for ; Sat, 7 Jul 2018 11:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ADFB21EA3 for ; Sat, 7 Jul 2018 11:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ADFB21EA3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbeGGLHQ (ORCPT ); Sat, 7 Jul 2018 07:07:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51176 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbeGGLHN (ORCPT ); Sat, 7 Jul 2018 07:07:13 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8E78211AB72AE; Sat, 7 Jul 2018 04:07:11 -0700 (PDT) Date: Sat, 07 Jul 2018 20:07:09 +0900 (KST) Message-Id: <20180707.200709.254416544610589415.davem@davemloft.net> To: arnd@arndb.de Cc: jiri@mellanox.com, idosch@mellanox.com, petrm@mellanox.com, arkadis@mellanox.com, dsahern@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] mlxsw: spectrum_router: avoid uninitialized variable access From: David Miller In-Reply-To: <20180706124455.3151925-1-arnd@arndb.de> References: <20180706124455.3151925-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Jul 2018 04:07:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 6 Jul 2018 14:44:45 +0200 > When CONFIG_BRIDGE_VLAN_FILTERING is disabled, gcc correctly points out > that the 'vid' variable is uninitialized whenever br_vlan_get_pvid > returns an error: > > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_rif_vlan_fid_get': > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:6881:6: error: 'vid' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This changes the condition check to always return -EINVAL here, > which I guess is what the author intended here. > > Fixes: e6f1960ae6c7 ("mlxsw: spectrum_router: Allocate FID according to PVID") > Signed-off-by: Arnd Bergmann Applied.