From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35078C6778F for ; Sat, 7 Jul 2018 11:16:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF1E02238F for ; Sat, 7 Jul 2018 11:16:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF1E02238F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbeGGLP6 (ORCPT ); Sat, 7 Jul 2018 07:15:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbeGGLP4 (ORCPT ); Sat, 7 Jul 2018 07:15:56 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 136F711AEC6EB; Sat, 7 Jul 2018 04:15:54 -0700 (PDT) Date: Sat, 07 Jul 2018 20:15:53 +0900 (KST) Message-Id: <20180707.201553.20530216509400327.davem@davemloft.net> To: keescook@chromium.org Cc: saeedm@mellanox.com, tariqt@mellanox.com, leon@kernel.org, vadimp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5: Use 2-factor allocator calls From: David Miller In-Reply-To: <20180704172847.GA33621@beast> References: <20180704172847.GA33621@beast> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Jul 2018 04:15:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Wed, 4 Jul 2018 10:28:47 -0700 > This restores the use of 2-factor allocation helpers that were already > fixed treewide. Please do not use open-coded multiplication; prefer, > instead, using 2-factor allocation helpers. > > Signed-off-by: Kees Cook Saeed and co., please review.