From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <mawilcox@microsoft.com>,
valdis.kletnieks@vt.edu
Subject: Re: [PATCH] radix-tree: avoid NULL dereference
Date: Fri, 6 Jul 2018 17:14:36 -0700 [thread overview]
Message-ID: <20180707001436.GA31699@bombadil.infradead.org> (raw)
In-Reply-To: <20180706144534.be6de0d9222e9755a3a09a2e@linux-foundation.org>
On Fri, Jul 06, 2018 at 02:45:34PM -0700, Andrew Morton wrote:
> On Fri, 6 Jul 2018 16:36:41 +0100 Mark Rutland <mark.rutland@arm.com> wrote:
>
> > > >
> > > > Acked-by: Matthew Wilcox <willy@infradead.org>
> > >
> > > Cheers!
> > >
> > > I assume that Andrew will pick this up, if he's also happy with it.
> >
> > I've just started fuzzing, and found this also applies with
> > node_tag_set(). I'll spin a v2 with that fixed up, too.
>
> Thanks. Please also give some thought to whether the fix should be
> backported and if so, which patch(es) it Fixes:.
I would say this goes all the way back to
0a835c4f090 ("Reimplement IDR and IDA using the radix tree")
I don't know if it's worth backporting though. If the compiler does
the normal optimisation, nobody will hit it. If it doesn't, the first
use of an IDR will trip the bug. So it's not like a user-exploitable bug.
next prev parent reply other threads:[~2018-07-07 0:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:41 Mark Rutland
2018-07-06 14:25 ` Matthew Wilcox
2018-07-06 14:36 ` Mark Rutland
2018-07-06 15:36 ` Mark Rutland
2018-07-06 21:45 ` Andrew Morton
2018-07-07 0:14 ` Matthew Wilcox [this message]
2018-07-06 14:51 ` valdis.kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707001436.GA31699@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mawilcox@microsoft.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®