mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tamir Suliman <tsuliman@linuxvaults.com>
Cc: w.d.hubbs@gmail.com, speakup@linux-speakup.org,
	dhowells@redhat.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, chris@the-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging
Date: Sat, 7 Jul 2018 16:05:18 +0200	[thread overview]
Message-ID: <20180707140518.GB7052@kroah.com> (raw)
In-Reply-To: <1530756740-14168-1-git-send-email-tsuliman@linuxvaults.com>

On Thu, Jul 05, 2018 at 02:12:20AM +0000, Tamir Suliman wrote:
> Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin.
> then later noticed that I forgot to add a space on printk.
> 
> Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 7e79f99..af664f0 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
>  			snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
>  				 " with %d reject%s\n",
>  				 rejected, rejected > 1 ? "s" : "");
> -		printk(KERN_INFO "i18n messages rejected\n",buf);
> +		printk(KERN_INFO "i18n messages rejected\n", buf);
>  	}
>  }
>  
> -- 
> 1.8.3.1

Where are patches 1 and 2 of this series?

And the changelog text does not match what the text itself does, so I
can't take this as-is :(

greg k-h

      reply	other threads:[~2018-07-07 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  2:12 Tamir Suliman
2018-07-07 14:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180707140518.GB7052@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@the-brannons.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=speakup@linux-speakup.org \
    --cc=tsuliman@linuxvaults.com \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®