From: Petr Mladek <pmladek@suse.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Namit Gupta <gupta.namit@samsung.com>,
linux-kernel@vger.kernel.org, pankaj.m@samsung.com,
a.sahrawat@samsung.com, himanshu.m@samsung.com
Subject: Re: [PATCH] printk: remove unnecessary kmalloc() from syslog during clear
Date: Mon, 9 Jul 2018 13:48:37 +0200 [thread overview]
Message-ID: <20180709114837.zhzwmtcff2y3bl6i@pathway.suse.cz> (raw)
In-Reply-To: <20180627150641.p56xyy6mdzvnfpig@pathway.suse.cz>
On Wed 2018-06-27 17:06:41, Petr Mladek wrote:
> On Tue 2018-06-26 10:39:59, Steven Rostedt wrote:
> > This looks fine. For proper history though, what I do in this case,
> > would be to make this into two patches. One with Namit's original
> > patch, and then a second that removes the code duplication (your patch).
>
> Proposed patch:
>
> From: Petr Mladek <pmladek@suse.com>
> Date: Wed, 27 Jun 2018 16:37:42 +0200
> Subject: [PATCH] printk: Clean up syslog_print_all()
>
> syslog_print_all() is called twice. Once with a valid buffer
> and once just to set the indexes.
>
> Both variants are already handled separately. This patch just
> makes it more obvious. It does not change the existing behavior.
JFYI, I have pushed this separate clean up patch into printk.git,
branch for-4.19.
Best Regards,
Petr
prev parent reply other threads:[~2018-07-09 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180620135951epcas5p3bd2a8f25ec689ca333bce861b527dba2@epcas5p3.samsung.com>
2018-06-20 13:56 ` Namit Gupta
2018-06-20 14:16 ` Steven Rostedt
2018-06-21 6:58 ` Sergey Senozhatsky
2018-06-25 13:37 ` Petr Mladek
2018-06-25 13:42 ` Jiri Kosina
2018-06-25 14:35 ` Sergey Senozhatsky
2018-06-25 14:37 ` Steven Rostedt
2018-06-25 14:44 ` Sergey Senozhatsky
2018-06-26 12:43 ` Petr Mladek
2018-06-26 14:39 ` Steven Rostedt
2018-06-27 15:06 ` Petr Mladek
2018-07-09 11:48 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709114837.zhzwmtcff2y3bl6i@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=a.sahrawat@samsung.com \
--cc=gupta.namit@samsung.com \
--cc=himanshu.m@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®