From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
ioana.ciornei@nxp.com
Subject: [PATCH 1/5] staging: fsl-dpaa2/eth: Fix DMA mapping direction
Date: Mon, 9 Jul 2018 10:01:07 -0500 [thread overview]
Message-ID: <20180709150111.8875-2-ruxandra.radulescu@nxp.com> (raw)
In-Reply-To: <20180709150111.8875-1-ruxandra.radulescu@nxp.com>
We are using DMA_FROM_DEVICE when mapping RX frame buffers,
but DMA_BIDIRECTIONAL for unmap. Fix the direction for DMA
unmapping operation.
Fixes: 87eb55e418b7 ("staging: fsl-dpaa2/eth: Fix potential endless loop")
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
index 3963717..537d5bb 100644
--- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
+++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
@@ -767,7 +767,7 @@ static void free_bufs(struct dpaa2_eth_priv *priv, u64 *buf_array, int count)
for (i = 0; i < count; i++) {
vaddr = dpaa2_iova_to_virt(priv->iommu_domain, buf_array[i]);
dma_unmap_single(dev, buf_array[i], DPAA2_ETH_RX_BUF_SIZE,
- DMA_BIDIRECTIONAL);
+ DMA_FROM_DEVICE);
skb_free_frag(vaddr);
}
}
--
2.7.4
next prev parent reply other threads:[~2018-07-09 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:01 [PATCH 0/5] staging: fsl-dpaa2/eth: Cleanup and minor fixes Ioana Radulescu
2018-07-09 15:01 ` Ioana Radulescu [this message]
2018-07-09 15:01 ` [PATCH 2/5] staging: fsl-dpaa2/eth: Remove obsolete reference Ioana Radulescu
2018-07-09 15:01 ` [PATCH 3/5] staging: fsl-dpaa2/eth: Remove pointless instruction Ioana Radulescu
2018-07-09 15:01 ` [PATCH 4/5] staging: fsl-dpaa2/eth: MTU cleanup Ioana Radulescu
2018-07-09 15:01 ` [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check Ioana Radulescu
2018-07-09 19:28 ` Dan Carpenter
2018-07-10 15:55 ` Ioana Ciocoi Radulescu
2018-07-10 16:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709150111.8875-2-ruxandra.radulescu@nxp.com \
--to=ruxandra.radulescu@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®