From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: pascal paillet <p.paillet@st.com>,
benjamin.gaignard@linaro.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Don't link consumers on the same device
Date: Mon, 9 Jul 2018 17:11:52 +0100 [thread overview]
Message-ID: <20180709161152.GH16082@sirena.org.uk> (raw)
In-Reply-To: <20180709133215eucas1p138cd9714d802a446973ce90058ef0afb~-tpG-E94E1650416504eucas1p1I@eucas1p1.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On Mon, Jul 09, 2018 at 03:32:14PM +0200, Marek Szyprowski wrote:
> This patch doesn't help, because wm8994 creates separate struct device for
> each registered regulator, so you need to check the regulator parents too,
> see my fixes below in the patch.
Ugh, right - I'd not looked at enough of the context to see what was
being checked.
> I don't like such fixes for this specific case. It's not that uncommon
> that a complex device provides various functionalities used by its
> components, so it is not a bad design to use regulator provided by
> its parent/grandparent/other ancestor device.
> Frankly, either the device_is_dependent() function should be exported and
> used in regulator core or device_link_add() should have another flag:
> DL_FLAG_SKIP_DEPENDANT.
Or it should just make the warning optional at the core level.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-07-09 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180709125425epcas1p2343265d3a6a826b2ace0ef584d062dac@epcas1p2.samsung.com>
2018-07-09 12:54 ` Mark Brown
2018-07-09 13:32 ` Marek Szyprowski
2018-07-09 16:11 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709161152.GH16082@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=benjamin.gaignard@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=p.paillet@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®