From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B15C5CFE7 for ; Mon, 9 Jul 2018 17:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 763C8208A5 for ; Mon, 9 Jul 2018 17:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="O8Uua1Js" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 763C8208A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933745AbeGIRKm (ORCPT ); Mon, 9 Jul 2018 13:10:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:55258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933364AbeGIRKl (ORCPT ); Mon, 9 Jul 2018 13:10:41 -0400 Received: from localhost (unknown [106.201.46.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2D7920871; Mon, 9 Jul 2018 17:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531156240; bh=S2SRd74Sj9T5eX2eyIlX5JtPkaGoBi6f/8cX3t7yjeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O8Uua1Js1grCndzN1Lgqv4c77OV07z0Xg78ZcZ5ZrTyah8K2s0ZYnBP5+0LZ7+t3S 4Ntv1SaTVUej9kfkfHk9F0zEYbuwFO546xEo2QMMnqZ+8HAbd6GDDPhcPiryh8mp4p Xe54O1hSwP5wKutSp17Qvubq7310cJW1LpNGSuTU= Date: Mon, 9 Jul 2018 22:40:32 +0530 From: Vinod To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC Message-ID: <20180709171032.GJ22377@vkoul-mobl> References: <20180703123214.23090-1-paul@crapouillou.net> <20180703123214.23090-5-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703123214.23090-5-paul@crapouillou.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-07-18, 14:32, Paul Cercueil wrote: > +static inline void jz4780_dma_chan_disable(struct jz4780_dma_dev *jzdma, > + unsigned int chn) > +{ > + if (jzdma->version == ID_JZ4770) > + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKEC, BIT(chn)); > +} this sounds as hardware behaviour, so why not describe as a property in DT? > + > static struct jz4780_dma_desc *jz4780_dma_desc_alloc( > struct jz4780_dma_chan *jzchan, unsigned int count, > enum dma_transaction_type type) > @@ -228,8 +246,15 @@ static void jz4780_dma_desc_free(struct virt_dma_desc *vdesc) > kfree(desc); > } > > -static uint32_t jz4780_dma_transfer_size(unsigned long val, uint32_t *shift) > +static const unsigned int jz4780_dma_ord_max[] = { > + [ID_JZ4770] = 6, > + [ID_JZ4780] = 7, > +}; So this gives the transfer length supported? -- ~Vinod