From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH] objtool: move libelf detection to Kconfig from Makefile
Date: Mon, 9 Jul 2018 14:21:34 -0500 [thread overview]
Message-ID: <20180709192134.vhd4lh443fymthfs@treble> (raw)
In-Reply-To: <1531043982-13325-1-git-send-email-yamada.masahiro@socionext.com>
On Sun, Jul 08, 2018 at 06:59:42PM +0900, Masahiro Yamada wrote:
> Currently, users are allowed to enable STACK_VALIDATION regardless
> of the compiler capability. The top-level Makefile warns or breaks
> the build if it turns out that the host compiler cannot link libelf.
>
> Move the libelf test to Kconfig so that users can enable the feature
> only when the host compiler can build the objtool. The ugly check
> in the Makefile will go away.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks for cleaning this up!
> I am sure about this patch only from the build system point of view.
>
> Please review this from x86 and objtool point of view.
>
> In my understanding:
>
> - UNWINDER_ORC _requires_ objtool,
> so I added 'depends on STACK_VALIDATION'.
> ('select' would end up with unmet depenency)
Correct.
> - RETPOLINE _wants_ objtool, so I added 'imply'
Yeah, I think this is fine.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2018-07-09 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 9:59 Masahiro Yamada
2018-07-09 19:21 ` Josh Poimboeuf [this message]
2018-07-09 23:17 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709192134.vhd4lh443fymthfs@treble \
--to=jpoimboe@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®