From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21669C5CFEB for ; Mon, 9 Jul 2018 22:10:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6522920881 for ; Mon, 9 Jul 2018 22:10:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cl3jKBpm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6522920881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbeGIWKP (ORCPT ); Mon, 9 Jul 2018 18:10:15 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:45864 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbeGIWKK (ORCPT ); Mon, 9 Jul 2018 18:10:10 -0400 Received: by mail-pl0-f67.google.com with SMTP id a17-v6so806597plm.12; Mon, 09 Jul 2018 15:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0htPzSwKKUku2M3VEDTBQ014ZUm0EIx5ffWobFOq5Hs=; b=Cl3jKBpm57u13BaJHKiMixgIU113mBpRFup+5DMV4Eoacw7QDyE9S5qSlcW1ElmZvm JfS4nHak2eYk3p94fHGZeP8gYQi9E/mFXMUOYw1jMltGGQjEgmsdIds63O4WwPnXOYwY Pzo2+vbZZtm2n28EujiY20ciy1llqA++TJ2f4OCP9zi/Sgmi1hY+ym4WQzvGvCDQguQy +lpk3MXLXxzM7AyVknP3TTDfgklqtW03CYkugNQJistjgzmQ0lGQnNDvnRzBfhvKhoj7 vP+x4MWV5Ms4+eZ7SQlDvEMj7jG5tfLlUCSemD7+SdFysbUy4EqWmzzCU5QRVeu4YQeW 550g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0htPzSwKKUku2M3VEDTBQ014ZUm0EIx5ffWobFOq5Hs=; b=pOBdZBb+uq1M/osx4CEiJntPer1qi1CYDF3RwR1TE0aMzw2dJfC+xHn977A213Q7UT hZcuEZFevCqrc01eaY80/JpPYUlrjalusJShAiSrlzvey7mM2vquMgGlC59XL90WJ4XR KJtfhaZAOLKXg9ewy+Vn41Whv0keXtlH9OI9BmLfkWKJG8/lZYuTvbJjbNtIjWr/Ct7N dxHF7C6FXV4cmG6pIZpQ0etZ7l4VMO9vVMlRRv0R84f4AhjU1lbUNP2qsZainU4sHkqA 710uAWcNn+vs20i3lyFdgvl0c1Eg1/Fv0IkUBalxkofdkbmVuqt3eiFYFmtywtCzNUR7 lxNQ== X-Gm-Message-State: APt69E3WkU2uQ3WJ1QgD8Qo6crmsMuqPiK65J+LZ+VYDUTe4M4Kxme8F VHbTRp/8qN0IO+W3BtWyDL4= X-Google-Smtp-Source: AAOMgpfJ/NsOzN/EsabAiizimlUSLMYDBTaz2JQtMfijLJgH9rFtOhkeUdrxN7FUlHzHu4jPlC1XEg== X-Received: by 2002:a17:902:d711:: with SMTP id w17-v6mr21703115ply.200.1531174209642; Mon, 09 Jul 2018 15:10:09 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::7:7b66]) by smtp.gmail.com with ESMTPSA id h16-v6sm24192809pfn.80.2018.07.09.15.10.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 15:10:08 -0700 (PDT) Date: Mon, 9 Jul 2018 15:10:07 -0700 From: Alexei Starovoitov To: Daniel Colascione Cc: Mathieu Desnoyers , Joel Fernandes , Alexei Starovoitov , linux-kernel , Tim Murray , Daniel Borkmann , netdev , Chenbo Feng Subject: Re: [RFC] Add BPF_SYNCHRONIZE bpf(2) command Message-ID: <20180709221005.sintsjkle4xpkcyk@ast-mbp.dhcp.thefacebook.com> References: <20180707015616.25988-1-dancol@google.com> <20180707025426.ssxipi7hsehoiuyo@ast-mbp.dhcp.thefacebook.com> <20180707203340.GA74719@joelaf.mtv.corp.google.com> <951478560.1636.1531083278064.JavaMail.zimbra@efficios.com> <20180709210944.quulirpmv3ydytk7@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 09, 2018 at 02:36:37PM -0700, Daniel Colascione wrote: > On Mon, Jul 9, 2018 at 2:09 PM, Alexei Starovoitov > wrote: > > On Sun, Jul 08, 2018 at 04:54:38PM -0400, Mathieu Desnoyers wrote: > >> ----- On Jul 7, 2018, at 4:33 PM, Joel Fernandes joelaf@google.com wrote: > >> > >> > On Fri, Jul 06, 2018 at 07:54:28PM -0700, Alexei Starovoitov wrote: > >> >> On Fri, Jul 06, 2018 at 06:56:16PM -0700, Daniel Colascione wrote: > >> >> > BPF_SYNCHRONIZE waits for any BPF programs active at the time of > >> >> > BPF_SYNCHRONIZE to complete, allowing userspace to ensure atomicity of > >> >> > RCU data structure operations with respect to active programs. For > >> >> > example, userspace can update a map->map entry to point to a new map, > >> >> > use BPF_SYNCHRONIZE to wait for any BPF programs using the old map to > >> >> > complete, and then drain the old map without fear that BPF programs > >> >> > may still be updating it. > >> >> > > >> >> > Signed-off-by: Daniel Colascione > >> >> > --- > >> >> > include/uapi/linux/bpf.h | 1 + > >> >> > kernel/bpf/syscall.c | 14 ++++++++++++++ > >> >> > 2 files changed, 15 insertions(+) > >> >> > > >> >> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > >> >> > index b7db3261c62d..4365c50e8055 100644 > >> >> > --- a/include/uapi/linux/bpf.h > >> >> > +++ b/include/uapi/linux/bpf.h > >> >> > @@ -98,6 +98,7 @@ enum bpf_cmd { > >> >> > BPF_BTF_LOAD, > >> >> > BPF_BTF_GET_FD_BY_ID, > >> >> > BPF_TASK_FD_QUERY, > >> >> > + BPF_SYNCHRONIZE, > >> >> > }; > >> >> > > >> >> > enum bpf_map_type { > >> >> > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > >> >> > index d10ecd78105f..60ec7811846e 100644 > >> >> > --- a/kernel/bpf/syscall.c > >> >> > +++ b/kernel/bpf/syscall.c > >> >> > @@ -2272,6 +2272,20 @@ SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, > >> >> > uattr, unsigned int, siz > >> >> > if (sysctl_unprivileged_bpf_disabled && !capable(CAP_SYS_ADMIN)) > >> >> > return -EPERM; > >> >> > > >> >> > + if (cmd == BPF_SYNCHRONIZE) { > >> >> > + if (uattr != NULL || size != 0) > >> >> > + return -EINVAL; > >> >> > + err = security_bpf(cmd, NULL, 0); > >> >> > + if (err < 0) > >> >> > + return err; > >> >> > + /* BPF programs are run with preempt disabled, so > >> >> > + * synchronize_sched is sufficient even with > >> >> > + * RCU_PREEMPT. > >> >> > + */ > >> >> > + synchronize_sched(); > >> >> > + return 0; > >> >> > >> >> I don't think it's necessary. sys_membarrier() can do this already > >> >> and some folks use it exactly for this use case. > >> > > >> > Alexei, the use of sys_membarrier for this purpose seems kind of weird to me > >> > though. No where does the manpage say membarrier should be implemented this > >> > way so what happens if the implementation changes? > >> > > >> > Further, membarrier manpage says that a memory barrier should be matched with > >> > a matching barrier. In this use case there is no matching barrier, so it > >> > makes it weirder. > >> > > >> > Lastly, sys_membarrier seems will not work on nohz-full systems, so its a bit > >> > fragile to depend on it for this? > >> > > >> > case MEMBARRIER_CMD_GLOBAL: > >> > /* MEMBARRIER_CMD_GLOBAL is not compatible with nohz_full. */ > >> > if (tick_nohz_full_enabled()) > >> > return -EINVAL; > >> > if (num_online_cpus() > 1) > >> > synchronize_sched(); > >> > return 0; > >> > > >> > > >> > Adding Mathieu as well who I believe is author/maintainer of membarrier. > >> > >> See commit 907565337 > >> "Fix: Disable sys_membarrier when nohz_full is enabled" > >> > >> "Userspace applications should be allowed to expect the membarrier system > >> call with MEMBARRIER_CMD_SHARED command to issue memory barriers on > >> nohz_full CPUs, but synchronize_sched() does not take those into > >> account." > >> > >> So AFAIU you'd want to re-use membarrier to issue synchronize_sched, and you > >> only care about kernel preempt off critical sections. > >> > >> Clearly bpf code does not run in user-space, so it would "work". > >> > >> But the guarantees provided by membarrier are not to synchronize against > >> preempt off per se. It's just that the current implementation happens to > >> do that. The point of membarrier is to turn user-space memory barriers > >> into compiler barriers. > >> > >> If what you need is to wait for a RCU grace period for whatever RCU flavor > >> ebpf is using, I would against using membarrier for this. I would rather > >> recommend adding a dedicated BPF_SYNCHRONIZE so you won't leak > >> implementation details to user-space, *and* you can eventually change you > >> RCU implementation for e.g. SRCU in the future if needed. > > > > The point about future changes to underlying bpf mechanisms is valid. > > There is work already on the way to reduce the scope of preempt_off+rcu_lock > > that currently lasts the whole prog. We will have new prog types that won't > > have such wrappers and will do rcu_lock/unlock and preempt on/off only > > when necessary. > > So something like BPF_SYNCHRONIZE will break soon, since the kernel cannot have > > guarantees on when programs finish. Calling this command BPF_SYNCHRONIZE_PROG > > also won't make sense for the same reason. > > What we can do it instead is to define synchronization barrier for > > programs accessing maps. May be call it something like: > > BPF_SYNC_MAP_ACCESS ? > > I'm not sure what you're proposing. In the case the commit message > describes, a user-space program that wants to "drain" a map needs to > be confident that the map won't change under it, even across multiple > bpf system calls on that map. One way of doing that is to ensure that > nothing that could possibly hold a reference to that map is still > running. Are you proposing some kind of refcount-draining approach? > Simple locking won't work, since BPF programs can't block, and I don't > see right now how a simple barrier would help. I'm proposing few changes for your patch: s/BPF_SYNCHRONIZE/BPF_SYNC_MAP_ACCESS/ and s/synchronize_sched/synchronize_rcu/ with detailed comment in uapi/bpf.h that has an example why folks would want to use this new cmd. I think the bpf maps will be rcu protected for foreseeable future even when rcu_read_lock/unlock will be done by the programs instead of kernel wrappers.