From: Mark Brown <broonie@kernel.org>
To: Radu Pirea <radu.pirea@microchip.com>
Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
lee.jones@linaro.org, richard.genoud@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
gregkh@linuxfoundation.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi
Date: Tue, 10 Jul 2018 19:15:59 +0100 [thread overview]
Message-ID: <20180710181559.GG8104@sirena.org.uk> (raw)
In-Reply-To: <20180625172230.29686-6-radu.pirea@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote:
This is mostly good, just a couple of small things:
> +config SPI_AT91_USART
> + tristate "Atmel USART Controller SPI driver"
> + depends on HAS_DMA
> + depends on (ARCH_AT91 || COMPILE_TEST)
> + select MFD_AT91_USART
Why is this selecting rather than depending on the MFD like we normally
do?
> @@ -0,0 +1,432 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Driver for AT91 USART Controllers as SPI
> + *
> + * Copyright (C) 2018 Microchip Technology Inc.
> + * Author: Radu Pirea <radu.pirea@microchip.com>
> + */
Please use C++ comments for the whole block so it looks a bit more
intentional.
Otherwise
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-10 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 17:22 [PATCH v10 0/6] Driver for at91 usart in spi mode Radu Pirea
2018-06-25 17:22 ` [PATCH v10 1/6] MAINTAINERS: add at91 usart mfd driver Radu Pirea
2018-07-04 6:23 ` Lee Jones
2018-06-25 17:22 ` [PATCH v10 2/6] dt-bindings: add binding for atmel-usart in SPI mode Radu Pirea
2018-07-04 6:23 ` Lee Jones
2018-06-25 17:22 ` [PATCH v10 3/6] mfd: at91-usart: added mfd driver for usart Radu Pirea
2018-06-25 17:22 ` [PATCH v10 4/6] MAINTAINERS: add at91 usart spi driver Radu Pirea
2018-06-25 17:22 ` [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi Radu Pirea
2018-07-10 18:15 ` Mark Brown [this message]
2018-07-13 9:56 ` Radu Pirea
2018-07-13 10:06 ` Alexandre Belloni
2018-06-25 17:22 ` [PATCH v10 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd Radu Pirea
2018-07-11 8:26 ` [PATCH v10 0/6] Driver for at91 usart in spi mode Nicolas Ferre
2018-07-13 7:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710181559.GG8104@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu.pirea@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome