From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6792FC5CFEB for ; Wed, 11 Jul 2018 06:54:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CD3320BEC for ; Wed, 11 Jul 2018 06:54:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD3320BEC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbeGKG4o (ORCPT ); Wed, 11 Jul 2018 02:56:44 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:50473 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbeGKG4o (ORCPT ); Wed, 11 Jul 2018 02:56:44 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fd90W-0001OK-Ah; Wed, 11 Jul 2018 08:53:48 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1fd90M-0008Ea-3j; Wed, 11 Jul 2018 08:53:38 +0200 Date: Wed, 11 Jul 2018 08:53:38 +0200 From: "s.hauer@pengutronix.de" To: Robin Gong Cc: Vinod , "dan.j.williams@intel.com" , "shawnguo@kernel.org" , Fabio Estevam , "linux@armlinux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest Message-ID: <20180711065338.3ka4yibxkawgo4fd@pengutronix.de> References: <1531239793-11781-1-git-send-email-yibin.gong@nxp.com> <1531239793-11781-4-git-send-email-yibin.gong@nxp.com> <20180710153326.GG3219@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:44:36 up 28 days, 15:53, 54 users, load average: 0.01, 0.06, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2018 at 06:37:02AM +0000, Robin Gong wrote: > > > -----Original Message----- > > From: Vinod [mailto:vkoul@kernel.org] > > Sent: 2018年7月10日 23:33 > > To: Robin Gong > > Cc: dan.j.williams@intel.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; Fabio Estevam ; > > linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; > > kernel@pengutronix.de; dmaengine@vger.kernel.org; > > linux-kernel@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest > > > > On 11-07-18, 00:23, Robin Gong wrote: > > > dmatest(memcpy) will never call dmaengine_slave_config before prep, > > > > and that should have been a hint to you that you should not expect that > > > > > so jobs in dmaengine_slave_config need to be moved into somewhere > > > before device_prep_dma_memcpy. Besides, dmatest never setup chan > > > ->private as other common case like uart/audio/spi will always setup > > > chan->private. Here check it to judge if it's dmatest case and do > > > jobs in slave_config. > > > > and you should not do anything for dmatest. Supporting it means memcpy > > implementation is not correct :) > Okay, I will any word about dmatest here since memcpy assume no calling > slave_config. > > > > > > > > Signed-off-by: Robin Gong > > > --- > > > drivers/dma/imx-sdma.c | 37 ++++++++++++++++++++++++++++--------- > > > 1 file changed, 28 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index > > > ed2267d..48f3749 100644 > > > --- a/drivers/dma/imx-sdma.c > > > +++ b/drivers/dma/imx-sdma.c > > > @@ -1222,10 +1222,36 @@ static int sdma_alloc_chan_resources(struct > > > dma_chan *chan) { > > > struct sdma_channel *sdmac = to_sdma_chan(chan); > > > struct imx_dma_data *data = chan->private; > > > + struct imx_dma_data default_data; > > > int prio, ret; > > > > > > - if (!data) > > > - return -EINVAL; > > > + ret = clk_enable(sdmac->sdma->clk_ipg); > > > + if (ret) > > > + return ret; > > > + ret = clk_enable(sdmac->sdma->clk_ahb); > > > + if (ret) > > > + goto disable_clk_ipg; > > > + /* > > > + * dmatest(memcpy) will never call dmaengine_slave_config before prep, > > > + * so jobs in dmaengine_slave_config need to be moved into somewhere > > > + * before device_prep_dma_memcpy. Besides, dmatest never setup chan > > > + * ->private as other common cases like uart/audio/spi will setup > > > + * chan->private always. Here check it to judge if it's dmatest case > > > + * and do jobs in slave_config. > > > + */ > > > + if (!data) { > > > + dev_warn(sdmac->sdma->dev, "dmatest is running?\n"); > > > > why is that a warning! > Current SDMA driver assume filter function to set chan->private with specific data > (struct imx_dma_data dma_data)like below (sound/soc/fsl/fsl_asrc_dma.c): > static bool filter(struct dma_chan *chan, void *param) > { > if (!imx_dma_is_general_purpose(chan)) > return false; > chan->private = param; > return true; > } > > But in memcpy case, at lease dmatest case, no chan->private set in its filter function. > So here take dmatest a special case and do some prepare jobs for memcpy. But if the > Upper device driver call dma_request_channel() with their specific filter without > 'chan->private' setting in the future. The warning message is a useful hint to them to > Add 'chan->private' in filter function. Or doc it somewhere? Instead of doing heuristics to guess whether we are doing memcpy you could instead make memcpy the default when slave_config is not called, i.e. drop the if (!data) check completely. > > > > > + sdmac->word_size = sdmac->sdma->dma_device.copy_align; > > > + default_data.priority = 2; > > > + default_data.peripheral_type = IMX_DMATYPE_MEMORY; > > > + default_data.dma_request = 0; > > > + default_data.dma_request2 = 0; > > > + data = &default_data; > > > + > > > + sdma_config_ownership(sdmac, false, true, false); > > > + sdma_get_pc(sdmac, IMX_DMATYPE_MEMORY); > > > + sdma_load_context(sdmac); > > > + } > > > > this needs to be default for memcpy The problem seems to be that we do not know whether we are doing memcpy or not. Normally we get the information how a channel is to be configured in dma_device->device_config, but this function is not called in the memcpy case. An alternative might also be to do the setup in dma_device->device_prep_dma_memcpy. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |