From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9C1C5CFEB for ; Wed, 11 Jul 2018 09:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF3012086B for ; Wed, 11 Jul 2018 09:26:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF3012086B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbeGKJaK (ORCPT ); Wed, 11 Jul 2018 05:30:10 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726490AbeGKJaK (ORCPT ); Wed, 11 Jul 2018 05:30:10 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DA9B40122BF; Wed, 11 Jul 2018 09:26:47 +0000 (UTC) Received: from localhost (unknown [10.43.2.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id ACC421C662; Wed, 11 Jul 2018 09:26:46 +0000 (UTC) Date: Wed, 11 Jul 2018 11:26:44 +0200 From: Stanislaw Gruszka To: Colin King Cc: Kalle Valo , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iwlegacy: remove several redundant variables Message-ID: <20180711092644.GA2114@redhat.com> References: <20180711074253.4192-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180711074253.4192-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Jul 2018 09:26:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Jul 2018 09:26:47 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'sgruszka@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2018 at 08:42:53AM +0100, Colin King wrote: > From: Colin Ian King > > Variables id, unicast, write, conf, a_band, accum_tx and ucode are > assigned a value but it is never read, hence they are redundant and > can be removed. > > Cleans up clang warnings: > warning: variable 'id' set but not used [-Wunused-but-set-variable] > warning: variable 'unicast' set but not used [-Wunused-but-set-variable] > warning: variable 'write' set but not used [-Wunused-but-set-variable] > warning: variable 'conf' set but not used [-Wunused-but-set-variable] > warning: variable 'a_band' set but not used [-Wunused-but-set-variable] > warning: variable 'tx' set but not used [-Wunused-but-set-variable] > warning: variable 'accum_tx' set but not used [-Wunused-but-set-variable] > warning: variable 'ucode' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King Acked-by: Stanislaw Gruszka