From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Whitmore <arigead@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, kstewart@linuxfoundation.org,
keescook@chromium.org, aastha.gupta4104@gmail.com,
linux-kernel@vger.kernel.org,
John Whitmore <johnfwhitmore@gmail.com>,
pombredanne@nexb.com, tglx@linutronix.de
Subject: Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
Date: Wed, 11 Jul 2018 17:29:43 +0300 [thread overview]
Message-ID: <20180711142943.chjedee3m7v6yogh@mwanda> (raw)
In-Reply-To: <20180711142710.GA12935@xux707-tw>
On Wed, Jul 11, 2018 at 03:27:11PM +0100, John Whitmore wrote:
> On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote:
> > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote:
> > > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote:
> > > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote:
> > > > > Corrected coding style issues aroung opening and closed parenthesis. Spaces, or blank line, removed from after '(' or before ')'
> > > >
> > > > Wrap your changelog text at 72 columns like your editor asked you to :(
> > > >
> > > > I'll fix it up this time...
> > >
> > > Oops sorry and thanks. I thought the magic number was 75 which I got from:
> > >
> > > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html
> >
> > 75 works as well :)
> >
>
> Well if I went over 75, which I knew about I'm very sorry I messed up. I'll
> keep an eye out in future. Might be using the wrong editor but let's not go
> there.
Here is the line:
Corrected coding style issues aroung opening and closed parenthesis. Spaces, or blank line, removed from after '(' or before ')'
It's 128 characters.
regards,
dan carpenter
next prev parent reply other threads:[~2018-07-11 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:05 [PATCH v2 0/8] staging:rtl8192u Coding style changes John Whitmore
2018-07-10 15:05 ` [PATCH v2 1/8] staging:rtl8192u: Remove blank lines before '}' and after '{' characters John Whitmore
2018-07-10 15:05 ` [PATCH v2 2/8] staging:rtl8192u: Correct indentation and spacing for braces of code blocks John Whitmore
2018-07-10 15:05 ` [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style John Whitmore
2018-07-11 11:13 ` Greg KH
2018-07-11 14:09 ` John Whitmore
2018-07-11 14:22 ` Greg KH
2018-07-11 14:27 ` John Whitmore
2018-07-11 14:29 ` Dan Carpenter [this message]
2018-07-11 14:39 ` John Whitmore
2018-07-10 15:05 ` [PATCH v2 4/8] staging:rtl8192u: Remove prohibited spaces - Coding Style John Whitmore
2018-07-10 15:05 ` [PATCH v2 5/8] staging:rtl8192u: Move trailing conditional statement to the following line John Whitmore
2018-07-10 15:05 ` [PATCH v2 6/8] staging:rtl8192u: Remove unnecessary parentheses - Coding Style John Whitmore
2018-07-10 15:05 ` [PATCH v2 7/8] staging:rtl8192u: Correct indentation of ieee80211_softmac_new_net() John Whitmore
2018-07-10 15:05 ` [PATCH v2 8/8] staging:rtl8192u: Correction of indentation issues - Coding Style John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711142943.chjedee3m7v6yogh@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aastha.gupta4104@gmail.com \
--cc=arigead@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®