From: Aapo Vienamo <avienamo@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
Date: Thu, 12 Jul 2018 10:52:47 +0300 [thread overview]
Message-ID: <20180712105247.121a5d13@dhcp-10-21-25-168> (raw)
In-Reply-To: <2d669942-0b4d-f48b-a8ba-67794485bf5f@nvidia.com>
On Wed, 11 Jul 2018 16:26:42 +0100
Jon Hunter <jonathanh@nvidia.com> wrote:
> On 11/07/18 16:23, Jon Hunter wrote:
> >
> > On 11/07/18 15:01, Aapo Vienamo wrote:
> >> Implement a function to query whether a pad is in deep power down mode.
> > Can you elaborate on why this public function is needed and who will be
> > using this?
>
> Or I should say does this need to be public?
It's only called from the pinconf callbacks and exposing it doesn't
indeed make much sense if we intend to replace direct calls to pmc.c
with pinctrl anyway. I'll make it private on the next iteration of the
series.
-Aapo
next prev parent reply other threads:[~2018-07-12 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 14:01 [PATCH v2 0/7] Tegra PMC pinctrl pad configuration Aapo Vienamo
2018-07-11 14:01 ` [PATCH v2 1/7] soc/tegra: pmc: Fix pad voltage configuration for Tegra186 Aapo Vienamo
2018-07-11 15:27 ` Jon Hunter
2018-07-11 14:01 ` [PATCH v2 2/7] soc/tegra: pmc: Factor out DPD register bit calculation Aapo Vienamo
2018-07-11 14:01 ` [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered() Aapo Vienamo
2018-07-11 15:23 ` Jon Hunter
2018-07-11 15:26 ` Jon Hunter
2018-07-12 7:52 ` Aapo Vienamo [this message]
2018-07-12 10:10 ` Jon Hunter
2018-07-11 14:01 ` [PATCH v2 4/7] soc/tegra: pmc: Use X macro to generate IO pad tables Aapo Vienamo
2018-07-11 14:05 ` [PATCH v2 5/7] dt-bindings: Add Tegra PMC pad configuration bindings Aapo Vienamo
2018-07-11 14:05 ` [PATCH v2 6/7] soc/tegra: pmc: Remove public pad voltage APIs Aapo Vienamo
2018-07-11 15:30 ` Jon Hunter
2018-07-12 0:05 ` kbuild test robot
2018-07-11 14:06 ` [PATCH v2 7/7] soc/tegra: pmc: Implement pad configuration via pinctrl Aapo Vienamo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712105247.121a5d13@dhcp-10-21-25-168 \
--to=avienamo@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®