From: Manfred Spraul <manfred@colorfullife.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Dmitry Vyukov <dvyukov@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
1vier1@web.de, Kees Cook <keescook@chromium.org>,
Manfred Spraul <manfred@colorfullife.com>
Subject: [PATCH 05/12] ipc/util.c: correct comment in ipc_obtain_object_check
Date: Thu, 12 Jul 2018 20:52:34 +0200 [thread overview]
Message-ID: <20180712185241.4017-6-manfred@colorfullife.com> (raw)
In-Reply-To: <20180712185241.4017-1-manfred@colorfullife.com>
The comment that explains ipc_obtain_object_check is wrong:
The function checks the sequence number, not the reference
counter.
Note that checking the reference counter would be meaningless:
The reference counter is decreased without holding any locks,
thus an object with kern_ipc_perm.deleted=true may disappear at
the end of the next rcu grace period.
Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
Reviewed-by: Davidlohr Bueso <dbueso@suse.de>
---
ipc/util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipc/util.c b/ipc/util.c
index cffd12240f67..5cc37066e659 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -628,8 +628,8 @@ struct kern_ipc_perm *ipc_lock(struct ipc_ids *ids, int id)
* @ids: ipc identifier set
* @id: ipc id to look for
*
- * Similar to ipc_obtain_object_idr() but also checks
- * the ipc object reference counter.
+ * Similar to ipc_obtain_object_idr() but also checks the ipc object
+ * sequence number.
*
* Call inside the RCU critical section.
* The ipc object is *not* locked on exit.
--
2.17.1
next prev parent reply other threads:[~2018-07-12 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 18:52 [PATCH 0/12 V3] ipc: cleanups & bugfixes, rhashtable update Manfred Spraul
2018-07-12 18:52 ` [PATCH 01/12] ipc: ipc: compute kern_ipc_perm.id under the ipc lock Manfred Spraul
2018-07-12 18:52 ` [PATCH 02/12] ipc: reorganize initialization of kern_ipc_perm.seq Manfred Spraul
2018-07-12 18:52 ` [PATCH 03/12] ipc/util.c: Use ipc_rcu_putref() for failues in ipc_addid() Manfred Spraul
2018-07-12 18:52 ` [PATCH 04/12] ipc: Rename ipcctl_pre_down_nolock() Manfred Spraul
2018-07-12 18:52 ` Manfred Spraul [this message]
2018-07-12 18:52 ` [PATCH 06/12] ipc: drop ipc_lock() Manfred Spraul
2018-07-12 18:52 ` [PATCH 07/12] lib/rhashtable: simplify bucket_table_alloc() Manfred Spraul
2018-07-12 18:52 ` [PATCH 08/12] lib/rhashtable: guarantee initial hashtable allocation Manfred Spraul
2018-07-12 18:52 ` [PATCH 09/12] ipc: get rid of ids->tables_initialized hack Manfred Spraul
2018-07-12 18:52 ` [PATCH 10/12] ipc: simplify ipc initialization Manfred Spraul
2018-07-12 18:52 ` [PATCH 11/12] ipc/util.c: Further variable name cleanups Manfred Spraul
2018-07-12 18:52 ` [PATCH 12/12] ipc/util.c: update return value of ipc_getref from int to bool Manfred Spraul
-- strict thread matches above, loose matches on Subject: below --
2018-07-09 15:10 [PATCH 0/12 V2] ipc: cleanups & bugfixes, rhashtable update Manfred Spraul
2018-07-09 15:10 ` [PATCH 05/12] ipc/util.c: correct comment in ipc_obtain_object_check Manfred Spraul
2018-07-09 18:46 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712185241.4017-6-manfred@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=1vier1@web.de \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dvyukov@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®