From: Felix Siegel <felix.siegel@online.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felix Siegel <felix.siegel@posteo.de>,
devel@driverdev.osuosl.org, John Joseph <jnjoseph@google.com>,
linux-kernel@vger.kernel.org, Rob Springer <rspringer@google.com>
Subject: Re: [PATCH 3/4] staging: gasket: fix multi line comments style
Date: Thu, 12 Jul 2018 22:44:13 +0200 [thread overview]
Message-ID: <20180712224413.cdc2714ee779bf7eaeabccc6@online.de> (raw)
In-Reply-To: <20180712195354.GB28761@kroah.com>
On Thu, 12 Jul 2018 21:53:54 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 12, 2018 at 09:27:14PM +0200, Felix Siegel wrote:
> > This patch fixes checkpatch.pl warnings:
> >
> > WARNING: Block comments should align the * on each line
> > Signed-off-by: Felix Siegel <felix.siegel@posteo.de>
>
> So close, I need a blank line before the signed-of-by line :(
>
> I'll go edit it by hand, but be more careful next time please...
>
> thanks,
>
> greg k-h
Sorry, I'll look out for it next time.
Strange though, they were all added with format-patch -s.
Regards,
Felix
next prev parent reply other threads:[~2018-07-12 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1531423694-22478-1-git-send-email-felix.siegel@posteo.de>
2018-07-12 19:27 ` [PATCH 2/4] staging: gasket: Move open-curly brace to match kernel code style Felix Siegel
2018-07-12 19:27 ` [PATCH 3/4] staging: gasket: fix multi line comments style Felix Siegel
2018-07-12 19:53 ` Greg Kroah-Hartman
2018-07-12 20:44 ` Felix Siegel [this message]
2018-07-12 19:27 ` [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style Felix Siegel
2018-07-12 19:53 ` Greg Kroah-Hartman
2018-07-12 19:42 ` [PATCH 1/4] staging: gasket: add SPDX-License-Identifier tag Greg Kroah-Hartman
2018-07-12 20:28 ` Felix Siegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712224413.cdc2714ee779bf7eaeabccc6@online.de \
--to=felix.siegel@online.de \
--cc=devel@driverdev.osuosl.org \
--cc=felix.siegel@posteo.de \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome