mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	bart.vanassche@wdc.com, hans.holmberg@cnexlabs.com,
	javier@cnexlabs.com, hlitz@ucsc.edu, igor.j.konopko@intel.com,
	marcin.dziegielewski@intel.com,
	"Matias Bjørling" <mb@lightnvm.io>
Subject: [GIT PULL 10/10] lightnvm: pblk: assume that chunks are closed on 1.2 devices
Date: Fri, 13 Jul 2018 10:48:45 +0200	[thread overview]
Message-ID: <20180713084845.19511-11-mb@lightnvm.io> (raw)
In-Reply-To: <20180713084845.19511-1-mb@lightnvm.io>

From: Hans Holmberg <hans.holmberg@cnexlabs.com>

We can't know if a block is closed or not on 1.2 devices, so assume
closed state to make sure that blocks are erased before writing.

Fixes: 32ef9412c114 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
 drivers/lightnvm/pblk-init.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index d023ea6116bc..537e98f2b24a 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -719,10 +719,11 @@ static int pblk_setup_line_meta_12(struct pblk *pblk, struct pblk_line *line,
 
 		/*
 		 * In 1.2 spec. chunk state is not persisted by the device. Thus
-		 * some of the values are reset each time pblk is instantiated.
+		 * some of the values are reset each time pblk is instantiated,
+		 * so we have to assume that the block is closed.
 		 */
 		if (lun_bb_meta[line->id] == NVM_BLK_T_FREE)
-			chunk->state =  NVM_CHK_ST_FREE;
+			chunk->state =  NVM_CHK_ST_CLOSED;
 		else
 			chunk->state = NVM_CHK_ST_OFFLINE;
 
-- 
2.11.0


  parent reply	other threads:[~2018-07-13  8:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:48 [GIT PULL 00/10] lightnvm updates for 4.19 Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 01/10] lightnvm: pblk: handle case when mw_cunits equals to 0 Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 02/10] lightnvm: move NVM_DEBUG to pblk Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 03/10] lightnvm: pblk: enable line minor version detection Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 04/10] lightnvm: Remove redundant rq->__data_len initialization Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 05/10] lightnvm: pblk: fix read_bitmap for 32bit archs Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 06/10] lightnvm: limit get chunk meta request size Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 07/10] lightnvm: pblk: expose generic disk name on pr_* msgs Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 08/10] lightnvm: pblk: mark expected switch fall-through Matias Bjørling
2018-07-13  8:48 ` [GIT PULL 09/10] lightnvm: pblk: add asynchronous partial read Matias Bjørling
2018-07-13  8:48 ` Matias Bjørling [this message]
2018-07-13 14:15 ` [GIT PULL 00/10] lightnvm updates for 4.19 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713084845.19511-11-mb@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@wdc.com \
    --cc=hans.holmberg@cnexlabs.com \
    --cc=hlitz@ucsc.edu \
    --cc=igor.j.konopko@intel.com \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.dziegielewski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®