From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E794DECDFAA for ; Mon, 16 Jul 2018 04:16:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94A5A208B2 for ; Mon, 16 Jul 2018 04:16:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eUqiLeUI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94A5A208B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727339AbeGPElH (ORCPT ); Mon, 16 Jul 2018 00:41:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:39612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbeGPElH (ORCPT ); Mon, 16 Jul 2018 00:41:07 -0400 Received: from localhost (unknown [49.207.49.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3601D208B2; Mon, 16 Jul 2018 04:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531714543; bh=eqWVWcaJsoRFimDPzpIRUbz7DG3ETmxMbiieLnzGCeA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUqiLeUI+s5dCj9UUNzzppLYRXESRQojDGS/yxPmLCnDWtupl3Eut9b4rmvxxWEEQ VE5Y29Njt9w/QOROaGtbaPyhrRbfDxIPE/g6Qji2TkdupAELbWZH6ATyZdy3tbVZ0v 2+k2cwNAXTkkrDHlhSDhgzcVbL+N5TQ6wurm0/UQ= Date: Mon, 16 Jul 2018 09:45:38 +0530 From: Vinod To: Linus Walleij Cc: linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson , Matt Mackall , Herbert Xu , Arnd Bergmann , linux-arm-msm@vger.kernel.org, Stephen Boyd , Timur Tabi , jhugo@codeaurora.org Subject: Re: [PATCH v5 3/6] crypto: Add Qcom prng driver Message-ID: <20180716041538.GZ3219@vkoul-mobl> References: <20180709061925.20276-1-vkoul@kernel.org> <20180709061925.20276-4-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-07-18, 12:16, Linus Walleij wrote: > On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul wrote: > > > This ports the Qcom prng from older hw_random driver. > > > > No change of functionality and move from hw_random to crypto > > APIs is done. > > > > Signed-off-by: Vinod Koul > > FWIW: > Reviewed-by: Linus Walleij Thanks > > +config CRYPTO_DEV_QCOM_RNG > > + tristate "Qualcomm Randon Number Generator Driver" > > Random speling error. Will fix, thanks for pointing > > +#include > > Do you need this? It seems like a platform device fair and square. It was required for of_device_get_match_data() but then the change is in subsequent patch, I should move that -- ~Vinod