From: Todd Poynor <toddpoynor@gmail.com>
To: Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>,
Ben Chan <benchan@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Zhongze Hu <frankhu@chromium.org>, Simon Que <sque@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Todd Poynor <toddpoynor@google.com>
Subject: [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups
Date: Mon, 16 Jul 2018 19:08:54 -0700 [thread overview]
Message-ID: <20180717020926.176408-1-toddpoynor@gmail.com> (raw)
From: Todd Poynor <toddpoynor@google.com>
Various fixes mainly from the chromium review of the gasket and apex
drivers. More to come.
Various (32):
staging: gasket: remove X86 Kconfig restriction
staging: gasket: fix typo in apex_enter_reset
staging: gasket: fix typo in gasket_core.h comments
staging: gasket: whitespace fix in gasket_page_table_init
staging: gasket: remove driver registration on class creation failure
staging: gasket: hold mutex on gasket driver unregistration
staging: gasket: Return EBUSY on mapping create when already in use
staging: gasket: Remove stale pointers on error allocating attr array
staging: gasket: convert gasket_mmap_has_permissions to bool return
staging: gasket: fix gasket_wait_with_reschedule timeout return code
staging: gasket: gasket_wait_with_reschedule use msleep
staging: gasket: gasket_wait_with_reschedule return when condition hit
staging: gasket: gasket_wait_with_reschedule use 32 bits of retry
count
staging: gasket: bail out of reset sequence on device callback error
staging: gasket: drop gasket_cdev_get_info, use container_of
staging: gasket: always allow root open for write
staging: gasket: annotate ioctl arg with __user
staging: gasket: gasket_enable_dev remove unnecessary variable
staging: gasket: remove code for no physical device
staging: gasket: fix class create bug handling
staging: gasket: remove unnecessary code in coherent allocator
staging: gasket: don't treat no device reset callback as an error
staging: gasket: gasket_mmap return error instead of valid BAR index
staging: gasket: apex_clock_gating simplify logic, reduce indentation
staging: gasket: apex_ioctl_check_permissions use bool return type
staging: gasket: gasket page table functions use bool return type
staging: gasket: remove else clause after return in if clause
staging: gasket: fix comment syntax in apex.h
staging: gasket: remove unnecessary parens in page table code
staging: gasket: gasket_mmap use PAGE_MASK
staging: gasket: remove extra parens in gasket_write_mappable_regions
staging: gasket: fix multi-line comment syntax in gasket_core.h
drivers/staging/gasket/Kconfig | 2 +-
drivers/staging/gasket/apex.h | 7 +-
drivers/staging/gasket/apex_driver.c | 79 ++++++++--------
drivers/staging/gasket/gasket_core.c | 105 +++++++++------------
drivers/staging/gasket/gasket_core.h | 11 ++-
drivers/staging/gasket/gasket_ioctl.c | 91 +++++++++---------
drivers/staging/gasket/gasket_ioctl.h | 4 +-
drivers/staging/gasket/gasket_page_table.c | 67 +++++++------
drivers/staging/gasket/gasket_page_table.h | 8 +-
drivers/staging/gasket/gasket_sysfs.c | 4 +-
10 files changed, 177 insertions(+), 201 deletions(-)
--
2.18.0.203.gfac676dfb9-goog
Patches changed from version 1:
staging: gasket: typo and whitespace cleanups
Split into new separate patches:
staging: gasket: whitespace fix in gasket_page_table_init
staging: gasket: fix typo in gasket_core.h comments
staging: gasket: fix typo in apex_enter_reset
staging: gasket: device registration error and unregister fixups
Split into new separate patches:
staging: gasket: remove driver registration on class creation failure
staging: gasket: hold mutex on gasket driver unregistration
staging: gasket: sysfs mapping creation fixups
Split into new separate patches:
staging: gasket: Return EBUSY on mapping create when already in use
staging: gasket: Remove stale pointers on error allocating attr array
staging: gasket: gasket_wait_with_reschedule fixups
Split into new separate patches:
staging: gasket: fix gasket_wait_with_reschedule timeout return code
staging: gasket: gasket_wait_with_reschedule use msleep
staging: gasket: gasket_wait_with_reschedule return when condition hit
staging: gasket: gasket_open use container_of()
Replaced by new patch:
staging: gasket: drop gasket_cdev_get_info, use container_of
staging: gasket: always allow root open for write
Add Reviewed-by from Dmitry Torokhov.
staging: gasket: gasket_enable_dev fixups
Split into new separate patches:
staging: gasket: gasket_enable_dev remove unnecessary variable
staging: gasket: remove code for no physical device
staging: gasket: fix class create bug handling
Add Reviewed-by from Dmitry Torokhov.
staging: gasket: gasket core error handling fixups
Split into new separate patches:
staging: gasket: don't treat no device reset callback as an error
staging: gasket: gasket_mmap return error instead of valid BAR index
staging: gasket: various cleanups
Split into new separate patches:
staging: gasket: apex_clock_gating simplify logic, reduce indentation
staging: gasket: apex_ioctl_check_permissions use bool return type
staging: gasket: gasket page table functions use bool return type
staging: gasket: remove else clause after return in if clause
staging: gasket: fix comment syntax in apex.h
staging: gasket: remove unnecessary parens in page table code
staging: gasket: gasket_mmap use PAGE_MASK
staging: gasket: remove extra parens in gasket_write_mappable_regions
staging: gasket: fix multi-line comment syntax in gasket_core.h
Patches dropped from version 1:
MAINTAINERS: Add maintainer for drivers/staging/gasket
Need to arrange a positive handoff from existing maintainer, not
available now.
staging: gasket: fix deadlock in pci driver unregister path
Wrapped PCI calls broken, needs a rewrite.
staging: gasket: don't release coherent mappings
Not necessary.
Patches unchanged from version 1:
staging: gasket: remove X86 Kconfig restriction
staging: gasket: convert gasket_mmap_has_permissions to bool return
staging: gasket: bail out of reset sequence on device callback error
staging: gasket: always allow root open for write
staging: gasket: annotate ioctl arg with __user
staging: gasket: remove unnecessary code in coherent allocator
next reply other threads:[~2018-07-17 2:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 2:08 Todd Poynor [this message]
2018-07-17 2:08 ` [PATCH 01/32] staging: gasket: remove X86 Kconfig restriction Todd Poynor
2018-07-19 9:25 ` Greg Kroah-Hartman
2018-07-17 2:08 ` [PATCH 02/32] staging: gasket: fix typo in apex_enter_reset Todd Poynor
2018-07-17 2:08 ` [PATCH 03/32] staging: gasket: fix typo in gasket_core.h comments Todd Poynor
2018-07-17 2:08 ` [PATCH 04/32] staging: gasket: whitespace fix in gasket_page_table_init Todd Poynor
2018-07-17 2:08 ` [PATCH 05/32] staging: gasket: remove driver registration on class creation failure Todd Poynor
2018-07-17 2:09 ` [PATCH 06/32] staging: gasket: hold mutex on gasket driver unregistration Todd Poynor
2018-07-17 2:09 ` [PATCH 07/32] staging: gasket: Return EBUSY on mapping create when already in use Todd Poynor
2018-07-17 2:09 ` [PATCH 08/32] staging: gasket: Remove stale pointers on error allocating attr array Todd Poynor
2018-07-17 2:09 ` [PATCH 09/32] staging: gasket: convert gasket_mmap_has_permissions to bool return Todd Poynor
2018-07-17 2:09 ` [PATCH 10/32] staging: gasket: fix gasket_wait_with_reschedule timeout return code Todd Poynor
2018-07-17 2:09 ` [PATCH 11/32] staging: gasket: gasket_wait_with_reschedule use msleep Todd Poynor
2018-07-17 10:08 ` Dan Carpenter
2018-07-17 2:09 ` [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit Todd Poynor
2018-07-17 10:13 ` Dan Carpenter
2018-07-17 11:12 ` Dan Carpenter
2018-07-17 19:53 ` Todd Poynor
2018-07-17 19:52 ` Todd Poynor
2018-07-17 2:09 ` [PATCH 13/32] staging: gasket: gasket_wait_with_reschedule use 32 bits of retry count Todd Poynor
2018-07-17 2:09 ` [PATCH 14/32] staging: gasket: bail out of reset sequence on device callback error Todd Poynor
2018-07-17 2:09 ` [PATCH 15/32] staging: gasket: drop gasket_cdev_get_info, use container_of Todd Poynor
2018-07-17 2:09 ` [PATCH 16/32] staging: gasket: always allow root open for write Todd Poynor
2018-07-17 10:22 ` Dan Carpenter
2018-07-17 18:50 ` Joe Perches
2018-07-17 19:04 ` Todd Poynor
2018-07-17 2:09 ` [PATCH 17/32] staging: gasket: annotate ioctl arg with __user Todd Poynor
2018-07-17 10:26 ` Dan Carpenter
2018-07-17 18:20 ` Todd Poynor
2018-07-17 2:09 ` [PATCH 18/32] staging: gasket: gasket_enable_dev remove unnecessary variable Todd Poynor
2018-07-17 2:09 ` [PATCH 19/32] staging: gasket: remove code for no physical device Todd Poynor
2018-07-17 2:09 ` [PATCH 20/32] staging: gasket: fix class create bug handling Todd Poynor
2018-07-17 2:09 ` [PATCH 21/32] staging: gasket: remove unnecessary code in coherent allocator Todd Poynor
2018-07-17 2:09 ` [PATCH 22/32] staging: gasket: don't treat no device reset callback as an error Todd Poynor
2018-07-17 2:09 ` [PATCH 23/32] staging: gasket: gasket_mmap return error instead of valid BAR index Todd Poynor
2018-07-17 2:09 ` [PATCH 24/32] staging: gasket: apex_clock_gating simplify logic, reduce indentation Todd Poynor
2018-07-17 2:09 ` [PATCH 25/32] staging: gasket: apex_ioctl_check_permissions use bool return type Todd Poynor
2018-07-17 2:09 ` [PATCH 26/32] staging: gasket: gasket page table functions " Todd Poynor
2018-07-17 2:09 ` [PATCH 27/32] staging: gasket: remove else clause after return in if clause Todd Poynor
2018-07-17 10:37 ` Dan Carpenter
2018-07-17 19:23 ` Todd Poynor
2018-07-17 2:09 ` [PATCH 28/32] staging: gasket: fix comment syntax in apex.h Todd Poynor
2018-07-17 2:09 ` [PATCH 29/32] staging: gasket: remove unnecessary parens in page table code Todd Poynor
2018-07-17 2:09 ` [PATCH 30/32] staging: gasket: gasket_mmap use PAGE_MASK Todd Poynor
2018-07-17 10:44 ` Dan Carpenter
2018-07-17 2:09 ` [PATCH 31/32] staging: gasket: remove extra parens in gasket_write_mappable_regions Todd Poynor
2018-07-17 2:09 ` [PATCH 32/32] staging: gasket: fix multi-line comment syntax in gasket_core.h Todd Poynor
2018-07-17 11:16 ` [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups Greg Kroah-Hartman
2018-07-17 11:25 ` Todd Poynor
2018-07-17 11:46 ` Todd Poynor
2018-07-17 11:53 ` Greg KH
2018-07-17 11:16 ` Greg Kroah-Hartman
2018-07-17 11:27 ` Todd Poynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717020926.176408-1-toddpoynor@gmail.com \
--to=toddpoynor@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=dtor@chromium.org \
--cc=frankhu@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sque@chromium.org \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome