mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: akpm@linux-foundation.org, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH]  psi-pressure-stall-information-for-cpu-memory-and-io-fix-fix-fix
Date: Tue, 17 Jul 2018 15:51:24 +0200	[thread overview]
Message-ID: <20180717135133.3627980-1-arnd@arndb.de> (raw)

The addition of do_div() did not do the right thing, as it assigned the
result of the multiplication to an 'unsigned long', which truncates
it before the division. GCC warns in various ways about this depending
on the architecuture, e.g.

arch/arm/include/asm/div64.h:33:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'long unsigned int *'

This uses div_u64() instead. This is probably still a bad idea since
we should avoid 64-bit division altogether in the scheduler, but at
least it does the correct calculation.

Fixes: 13a67bcb35f5 ("psi-pressure-stall-information-for-cpu-memory-and-io-fix-fix")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Please fold into the fix
---
 kernel/sched/psi.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index eefe988ea7ce..9c3255ff50df 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -173,11 +173,10 @@ void __init psi_init(void)
 
 static void calc_avgs(unsigned long avg[3], u64 time, int missed_periods)
 {
-	unsigned long pct;
+	u64 pct;
 
 	/* Sample the most recent active period */
-	pct = time * 100;
-	do_div(pct, psi_period);
+	pct = div_u64(time * 100, psi_period);
 	pct *= FIXED_1;
 	avg[0] = calc_load(avg[0], EXP_10s, pct);
 	avg[1] = calc_load(avg[1], EXP_60s, pct);
-- 
2.9.0


             reply	other threads:[~2018-07-17 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 13:51 Arnd Bergmann [this message]
2018-07-17 15:17 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717135133.3627980-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome