From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Will Deacon <will.deacon@arm.com>, Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH] x86/pvqspinlock: Use LOCK_PREFIX in __pv_queued_spin_unlock assembly code
Date: Wed, 18 Jul 2018 10:19:18 +0200 [thread overview]
Message-ID: <20180718081918.GO2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1531858560-21547-1-git-send-email-longman@redhat.com>
On Tue, Jul 17, 2018 at 04:16:00PM -0400, Waiman Long wrote:
> The LOCK_PREFIX macro should be used in the assembly
> __raw_callee_save___pv_queued_spin_unlock code so that the lock prefix
> can be patched out on UP systems.
True; but does paravirt locking realy make sense on UP guests?
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> arch/x86/include/asm/qspinlock_paravirt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/qspinlock_paravirt.h b/arch/x86/include/asm/qspinlock_paravirt.h
> index 9ef5ee0..159622e 100644
> --- a/arch/x86/include/asm/qspinlock_paravirt.h
> +++ b/arch/x86/include/asm/qspinlock_paravirt.h
> @@ -43,7 +43,7 @@
> "push %rdx;"
> "mov $0x1,%eax;"
> "xor %edx,%edx;"
> - "lock cmpxchg %dl,(%rdi);"
> + LOCK_PREFIX "cmpxchg %dl,(%rdi);"
> "cmp $0x1,%al;"
> "jne .slowpath;"
> "pop %rdx;"
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2018-07-18 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 20:16 Waiman Long
2018-07-18 8:19 ` Peter Zijlstra [this message]
2018-07-18 13:28 ` Waiman Long
2018-07-25 14:20 ` [tip:locking/urgent] locking/pvqspinlock/x86: Use LOCK_PREFIX in __pv_queued_spin_unlock() " tip-bot for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718081918.GO2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jmario@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome