From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667E4ECDFB8 for ; Wed, 18 Jul 2018 09:55:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BD8D2075C for ; Wed, 18 Jul 2018 09:55:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BD8D2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730897AbeGRKc1 (ORCPT ); Wed, 18 Jul 2018 06:32:27 -0400 Received: from mga05.intel.com ([192.55.52.43]:22368 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbeGRKc1 (ORCPT ); Wed, 18 Jul 2018 06:32:27 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2018 02:55:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,369,1526367600"; d="scan'208";a="65556826" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jul 2018 02:55:14 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 3C9FE203A8; Wed, 18 Jul 2018 12:55:14 +0300 (EEST) Date: Wed, 18 Jul 2018 12:55:14 +0300 From: Sakari Ailus To: Yong Cc: Sakari Ailus , Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Linus Walleij , Randy Dunlap , Hans Verkuil , Arnd Bergmann , Stanimir Varbanov , Philipp Zabel , Ramesh Shanmugasundaram , Jacob Chen , Yannick Fertre , Thierry Reding , Benjamin Gaignard , Todor Tomov , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v10 2/2] media: V3s: Add support for Allwinner CSI. Message-ID: <20180718095513.4cm77g2iuilvfmd6@paasikivi.fi.intel.com> References: <1525417745-37964-1-git-send-email-yong.deng@magewell.com> <20180626110821.wkal6fcnoncsze6y@valkosipuli.retiisi.org.uk> <20180705154802.03604f156709be11892b19c0@magewell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180705154802.03604f156709be11892b19c0@magewell.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yong, On Thu, Jul 05, 2018 at 03:48:02PM +0800, Yong wrote: > > > + > > > +/* ----------------------------------------------------------------------------- > > > + * Media Operations > > > + */ > > > +static int sun6i_video_formats_init(struct sun6i_video *video, > > > + const struct media_pad *remote) > > > +{ > > > + struct v4l2_subdev_mbus_code_enum mbus_code = { 0 }; > > > + struct sun6i_csi *csi = video->csi; > > > + struct v4l2_format format; > > > + struct v4l2_subdev *subdev; > > > + u32 pad; > > > + const u32 *pixformats; > > > + int pixformat_count = 0; > > > + u32 subdev_codes[32]; /* subdev format codes, 32 should be enough */ > > > + int codes_count = 0; > > > + int num_fmts = 0; > > > + int i, j; > > > + > > > + pad = remote->index; > > > + subdev = media_entity_to_v4l2_subdev(remote->entity); > > > + if (subdev == NULL) > > > + return -ENXIO; > > > + > > > + /* Get supported pixformats of CSI */ > > > + pixformat_count = sun6i_csi_get_supported_pixformats(csi, &pixformats); > > > + if (pixformat_count <= 0) > > > + return -ENXIO; > > > + > > > + /* Get subdev formats codes */ > > > + mbus_code.pad = pad; > > > + mbus_code.which = V4L2_SUBDEV_FORMAT_ACTIVE; > > > + while (!v4l2_subdev_call(subdev, pad, enum_mbus_code, NULL, > > > + &mbus_code)) { > > > > The formats supported by the external sub-device may depend on horizontal > > and vertical flipping. You shouldn't assume any particular configuration > > here: instead, bridge drivers generally just need to make sure the formats > > match in link validation when streaming is started. At least the CSI-2 > > receiver driver and the DMA engine driver (video device) should check the > > configuration is valid. See e.g. the IPU3 driver: > > drivers/media/pci/intel/ipu3/ipu3-cio2.c . > > Can mbus_code be added dynamically ? > The code here only enum the mbus code and get the possible supported > pairs of pixformat and mbus by SoC. Not try to check if the formats > (width height ...) is valid or not. The formats validation will be > in link validation when streaming is started as per your advise. The formats that can be enumerated from the sensor here are those settable using SUBDEV_S_FMT. The enumeration will change on raw sensors if you use the flipping controls. As the bridge driver implements MC as well as subdev APIs, generally the sensor configuration is out of scope of this driver since it's directly configured from the user space. Just check that the pipeline is valid before starting streaming in your driver. -- Kind regards, Sakari Ailus sakari.ailus@linux.intel.com