From: Andrew Lunn <andrew@lunn.ch>
To: Camelia Groza <camelia.groza@nxp.com>
Cc: f.fainelli@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: use generic clause 45 autonegotiation done
Date: Wed, 18 Jul 2018 16:39:19 +0200 [thread overview]
Message-ID: <20180718143919.GA10856@lunn.ch> (raw)
In-Reply-To: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com>
On Wed, Jul 18, 2018 at 04:12:15PM +0300, Camelia Groza wrote:
> Only Clause 22 PHYs can use genphy_aneg_done(). Use
> genphy_c45_aneg_done() for PHYs that implement Clause 45 without
> the Clause 22 register set.
>
> This change follows the model of phy_restart_aneg() which
> differentiates between the two implementations in a similar way.
Hi Camelia
What about phy_config_aneg()? I would assume any sort of auto-neg
action needs to check for c45 without c22, before calling a genphy_
function. Do you think it is possible to write a
genphy_c45_config_aneg()? If not, we might want to return -EOPNOTSUPP.
Andrew
next prev parent reply other threads:[~2018-07-18 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 13:12 Camelia Groza
2018-07-18 14:39 ` Andrew Lunn [this message]
2018-07-19 12:47 ` Camelia Alexandra Groza
2018-07-19 12:56 ` Russell King - ARM Linux
2018-07-19 14:49 ` Andrew Lunn
2018-07-23 15:14 ` Camelia Alexandra Groza
2018-07-27 13:41 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718143919.GA10856@lunn.ch \
--to=andrew@lunn.ch \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome