From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
tom@herbertland.com, david.lebrun@uclouvain.be,
m.xhonneux@gmail.com, daniel@iogearbox.net, yuvalm@mellanox.com,
georg@hofmannsweb.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: ila: select CONFIG_DST_CACHE
Date: Thu, 19 Jul 2018 02:25:30 +0900 (KST) [thread overview]
Message-ID: <20180719.022530.2143546035904761995.davem@davemloft.net> (raw)
In-Reply-To: <20180718084909.1902331-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 18 Jul 2018 10:48:56 +0200
> My randconfig builds came across an old missing dependency for ILA:
>
> ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined!
>
> We almost never run into this by accident because randconfig builds
> end up selecting DST_CACHE from some other tunnel protocol, and this
> one appears to be the only one missing the explicit 'select'.
>
> From all I can tell, this problem first appeared in linux-4.9
> when dst_cache support got added to ILA.
>
> Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address")
> Cc: Tom Herbert <tom@herbertland.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
prev parent reply other threads:[~2018-07-18 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 8:48 Arnd Bergmann
2018-07-18 17:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719.022530.2143546035904761995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=daniel@iogearbox.net \
--cc=david.lebrun@uclouvain.be \
--cc=georg@hofmannsweb.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®