From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBA6ECDFBB for ; Wed, 18 Jul 2018 22:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB07F2084E for ; Wed, 18 Jul 2018 22:11:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB07F2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730451AbeGRWvn (ORCPT ); Wed, 18 Jul 2018 18:51:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44634 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbeGRWvn (ORCPT ); Wed, 18 Jul 2018 18:51:43 -0400 Received: from localhost (50-234-71-226-static.hfc.comcastbusiness.net [50.234.71.226]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1B10E147A4127; Wed, 18 Jul 2018 15:11:47 -0700 (PDT) Date: Thu, 19 Jul 2018 07:11:46 +0900 (KST) Message-Id: <20180719.071146.1992073818180515891.davem@davemloft.net> To: colin.king@canonical.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: sr: fix useless rol32 call on hash From: David Miller In-Reply-To: <20180717155254.30367-1-colin.king@canonical.com> References: <20180717155254.30367-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jul 2018 15:11:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 17 Jul 2018 16:52:54 +0100 > From: Colin Ian King > > The rol32 call is currently rotating hash but the rol'd value is > being discarded. I believe the current code is incorrect and hash > should be assigned the rotated value returned from rol32. > > Detected by CoverityScan, CID#1468411 ("Useless call") > > Fixes: b5facfdba14c ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode") > Signed-off-by: Colin Ian King Applied and queued up for -stable.