From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Anson Huang <Anson.Huang@nxp.com>,
s.hauer@pengutronix.de, kernel@pengutronix.de,
fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
Date: Thu, 19 Jul 2018 08:54:54 +0530 [thread overview]
Message-ID: <20180719032454.2bxp4eil7lfaijji@vireshk-i7> (raw)
In-Reply-To: <20180719032002.GT4576@dragon>
On 19-07-18, 11:20, Shawn Guo wrote:
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > this patch adds it.
> >
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> In general, when you send a patch fixing a commit, you should have the
> author of that commit copied. I added Viresh here.
>
> It looks like a wrong fix to me. It seems that commit b97872d4eb22
> shouldn't change imx7d.dtsi at all. So the correct fix would be
> reverting the change on imx7d.dtsi, @Viresh?
Wow! Can't believe such a stupid mistake got merged and no one noticed
:(
Please revert that patch and I will resend the right fix Shawn.
--
viresh
next prev parent reply other threads:[~2018-07-19 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 6:54 Anson Huang
2018-07-19 3:20 ` Shawn Guo
2018-07-19 3:24 ` Viresh Kumar [this message]
2018-07-19 3:26 ` Shawn Guo
2018-07-19 3:32 ` Viresh Kumar
2018-07-19 8:29 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719032454.2bxp4eil7lfaijji@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®