From: Peter Zijlstra <peterz@infradead.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mingo@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@suse.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v6] x86: Avoid pr_cont() in show_opcodes().
Date: Thu, 19 Jul 2018 15:56:05 +0200 [thread overview]
Message-ID: <20180719135605.GG2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1532008383-3797-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Thu, Jul 19, 2018 at 10:53:03PM +0900, Tetsuo Handa wrote:
> + if (probe_kernel_read(opcodes, rip - PROLOGUE_SIZE, OPCODE_BUFSIZE))
> + printk("%sCode: Bad RIP value.\n", loglvl);
> + else
> + printk("%sCode: %" __stringify(PROLOGUE_SIZE) "ph <%02x> %"
> + __stringify(EPILOGUE_SIZE) "ph\n", loglvl, opcodes,
> + opcodes[PROLOGUE_SIZE], opcodes + PROLOGUE_SIZE + 1);
> }
Kernel coding style wants { } on the else branch because multi-line, and
if we have { } on one leg of an if-else it should also be on the other.
prev parent reply other threads:[~2018-07-19 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:53 Tetsuo Handa
2018-07-19 13:56 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719135605.GG2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®