From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F371ECDFBB for ; Sat, 21 Jul 2018 07:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A6C20849 for ; Sat, 21 Jul 2018 07:45:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6A6C20849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbeGUIhL (ORCPT ); Sat, 21 Jul 2018 04:37:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48656 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbeGUIhK (ORCPT ); Sat, 21 Jul 2018 04:37:10 -0400 Received: from localhost (LFbn-1-12238-233.w90-92.abo.wanadoo.fr [90.92.53.233]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6BE16AEF; Sat, 21 Jul 2018 07:45:23 +0000 (UTC) Date: Sat, 21 Jul 2018 09:45:21 +0200 From: Greg KH To: rkir@google.com Cc: linux-kernel@vger.kernel.org, tkjos@google.com Subject: Re: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c Message-ID: <20180721074521.GB6484@kroah.com> References: <20180718001455.140575-1-rkir@google.com> <20180718001455.140575-2-rkir@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718001455.140575-2-rkir@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@google.com wrote: > From: Roman Kiryanov > > enums produce better compilation errors than defines. Yes, if you name the enum. But you didn't do that here, so this patch really does not do anything to cause any "protection" at all :( Please fix this up and resend. thanks, greg k-h