From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219E6C6778A for ; Sun, 22 Jul 2018 16:44:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C82420854 for ; Sun, 22 Jul 2018 16:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C82420854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730163AbeGVRl2 (ORCPT ); Sun, 22 Jul 2018 13:41:28 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729925AbeGVRl2 (ORCPT ); Sun, 22 Jul 2018 13:41:28 -0400 Received: from localhost (unknown [172.58.43.229]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5308D12DE5809; Sun, 22 Jul 2018 09:44:13 -0700 (PDT) Date: Sun, 22 Jul 2018 09:44:12 -0700 (PDT) Message-Id: <20180722.094412.532906090262121741.davem@davemloft.net> To: mst@redhat.com Cc: jasowang@redhat.com, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/9] TX used ring batched updating for vhost From: David Miller In-Reply-To: <20180722173622-mutt-send-email-mst@kernel.org> References: <1532045721-4958-1-git-send-email-jasowang@redhat.com> <20180722173622-mutt-send-email-mst@kernel.org> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 22 Jul 2018 09:44:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Sun, 22 Jul 2018 17:37:05 +0300 > On Fri, Jul 20, 2018 at 08:15:12AM +0800, Jason Wang wrote: >> Hi: >> >> This series implement batch updating of used ring for TX. This help to >> reduce the cache contention on used ring. The idea is first split >> datacopy path from zerocopy, and do only batching for datacopy. This >> is because zercopy had already supported its own batching. >> >> TX PPS was increased 25.8% and Netperf TCP does not show obvious >> differences. >> >> The split of datapath will also be helpful for future implementation >> like in order completion. >> >> Please review. >> >> Thanks > > Acked-by: Michael S. Tsirkin > > I'm very happy with the split, the mixed data path became hard to > maintain. Thanks for reviewing. Series applied, thanks everyone.