mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: [PATCH 18/28] ARM: tegra: apalis_t30: pinmux clean-up
Date: Sun, 22 Jul 2018 18:49:26 +0200	[thread overview]
Message-ID: <20180722164936.20581-19-marcel@ziswiler.com> (raw)
In-Reply-To: <20180722164936.20581-1-marcel@ziswiler.com>

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Clean-up pinmuxing:
- white-space clean-up
- explicitly disable input of BKL1_PWM and BKL1_PWM_EN#
- annotate Apalis I2C3 usage for CAM
- get rid of nvidia,lock property
- add missing eMMC sdmmc4_cmd_pt7 and explicitly enable input
- explicitly disable lcd_dc1_pd2 (e.g. LM95245 I2C address pin)
- annotate TOUCH_PEN_INT# being on-module

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 arch/arm/boot/dts/tegra30-apalis.dtsi | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index ef181d13be31..ac87eeebab03 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -68,10 +68,10 @@
 				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
 			};
 			dap3_fs_pp0 {
-				nvidia,pins =	"dap3_fs_pp0",
-						"dap3_sclk_pp3",
-						"dap3_din_pp1",
-						"dap3_dout_pp2";
+				nvidia,pins = "dap3_fs_pp0",
+					      "dap3_sclk_pp3",
+					      "dap3_din_pp1",
+					      "dap3_dout_pp2";
 				nvidia,function = "i2s2";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
@@ -91,6 +91,7 @@
 				nvidia,function = "pwm0";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
 			};
 			/* BKL1_PWM_EN#, disable TPS65911 PMIC PWM backlight */
 			uart3_cts_n_pa1 {
@@ -98,6 +99,7 @@
 				nvidia,function = "rsvd2";
 				nvidia,pull = <TEGRA_PIN_PULL_UP>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
 			};
 
 			/* Apalis CAN1 on SPI6 */
@@ -163,7 +165,7 @@
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 			};
 
-			/* Apalis I2C3 */
+			/* Apalis I2C3 (CAM) */
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1",
 					      "cam_i2c_sda_pbb2";
@@ -171,7 +173,6 @@
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
-				nvidia,lock = <TEGRA_PIN_DISABLE>;
 				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 
@@ -368,10 +369,12 @@
 			/* eMMC (On-module) */
 			sdmmc4_clk_pcc4 {
 				nvidia,pins = "sdmmc4_clk_pcc4",
+					      "sdmmc4_cmd_pt7",
 					      "sdmmc4_rst_n_pcc3";
 				nvidia,function = "sdmmc4";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 			};
 			sdmmc4_dat0_paa0 {
 				nvidia,pins = "sdmmc4_dat0_paa0",
@@ -385,6 +388,7 @@
 				nvidia,function = "sdmmc4";
 				nvidia,pull = <TEGRA_PIN_PULL_UP>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 			};
 
 			/* LVDS Transceiver Configuration */
@@ -397,7 +401,6 @@
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,lock = <TEGRA_PIN_DISABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3",
@@ -408,7 +411,6 @@
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,lock = <TEGRA_PIN_DISABLE>;
 			};
 
 			/* Power I2C (On-module) */
@@ -419,7 +421,6 @@
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
-				nvidia,lock = <TEGRA_PIN_DISABLE>;
 				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 
@@ -431,12 +432,12 @@
 			lcd_dc1_pd2 {
 				nvidia,pins = "lcd_dc1_pd2";
 				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
-				nvidia,tristate = <TEGRA_PIN_DISABLE>;
-				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
+				nvidia,tristate = <TEGRA_PIN_ENABLE>;
+				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
 			};
 
-			/* TOUCH_PEN_INT# */
+			/* TOUCH_PEN_INT# (On-module) */
 			pv0 {
 				nvidia,pins = "pv0";
 				nvidia,function = "rsvd1";
-- 
2.14.4


  parent reply	other threads:[~2018-07-22 16:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-22 16:49 [PATCH 00/28] ARM: dts: tegra: apalis_t30: major revamp incl. v1.1 hardware support Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 01/28] ARM: tegra: apalis_t30: enable broken-hpi on emmc Marcel Ziswiler
2018-07-24 14:03   ` Dmitry Osipenko
2018-07-24 14:26     ` Marcel Ziswiler
2018-07-24 14:55       ` Dmitry Osipenko
2018-07-25  8:40         ` Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 02/28] ARM: tegra: apalis_t30: fix mmc1 cmd pull-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 03/28] ARM: tegra: apalis_t30: pull-up sd card detect pins Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 04/28] ARM: tegra: apalis_t30: add local-mac-address property Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 05/28] ARM: tegra: apalis_t30: reorder pcie properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 06/28] ARM: tegra: apalis_t30: annotate pcie port nodes Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 07/28] ARM: tegra: apalis_t30: reorder host1x/hdmi properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 08/28] ARM: tegra: apalis_t30: regulator clean-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 09/28] ARM: tegra: apalis_t30: add missing regulators Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 10/28] ARM: tegra: apalis_t30: annotate uarts Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 11/28] ARM: tegra: apalis_t30: drop unused cami2c label Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 12/28] ARM: tegra: apalis_t30: white-space clean-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 13/28] ARM: tegra: apalis_t30: drop unused mmc1/sd1 labels Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 14/28] ARM: tegra: apalis_t30: annotate mmc1/sd1 Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 15/28] ARM: tegra: apalis_t30: move dr_mode property from phy to controller Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 16/28] ARM: tegra: apalis_t30: reorder backlight properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 17/28] ARM: tegra: apalis_t30: drop pwmleds Marcel Ziswiler
2018-07-22 16:49 ` Marcel Ziswiler [this message]
2018-07-22 16:49 ` [PATCH 19/28] ARM: tegra: apalis_t30: add missing pinmux Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 20/28] ARM: tegra: apalis_t30: use proper irq-gpio for stmpe811 Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 21/28] ARM: tegra: apalis_t30: further lm95245 temperature sensor annotation Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 22/28] ARM: tegra: apalis_t30: add i2c-thermtrip Marcel Ziswiler
2018-07-25 11:11   ` Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 23/28] ARM: tegra: apalis_t30: add proper emmc vmmc and vqmmc supplies Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 24/28] ARM: tegra: apalis_t30: enable emmc ddr52 mode Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 25/28] ARM: tegra: apalis_t30: rename clk to clock Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 26/28] ARM: tegra: apalis_t30: line break long compatible property line Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 27/28] ARM: tegra: apalis_t30: fix pcie switch vendor compatible Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 28/28] ARM: tegra: apalis_t30: support v1.1 hardware revision Marcel Ziswiler
2018-07-31 21:06   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180722164936.20581-19-marcel@ziswiler.com \
    --to=marcel@ziswiler.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®