From: Peter Zijlstra <peterz@infradead.org>
To: 王贇 <yun.wang@linux.alibaba.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tg: show the sum wait time of an task group
Date: Mon, 23 Jul 2018 11:31:21 +0200 [thread overview]
Message-ID: <20180723093121.GA2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ff7dae3b-e5f9-7157-1caa-ff02c6b23dc1@linux.alibaba.com>
On Wed, Jul 04, 2018 at 11:27:27AM +0800, 王贇 wrote:
> @@ -6788,6 +6790,12 @@ static int cpu_cfs_stat_show(struct seq_file *sf, void *v)
> seq_printf(sf, "nr_throttled %d\n", cfs_b->nr_throttled);
> seq_printf(sf, "throttled_time %llu\n", cfs_b->throttled_time);
>
> + if (schedstat_enabled() && tg != &root_task_group) {
I put the variables here.
> + for_each_possible_cpu(i)
> + ws += schedstat_val(tg->se[i]->statistics.wait_sum);
This doesn't quite work on 32bit archs, but I'm not sure I care enough
to be bothered about that.
> + seq_printf(sf, "wait_sum %llu\n", ws);
> + }
next prev parent reply other threads:[~2018-07-23 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 7:29 [RFC PATCH] tg: count " 王贇
2018-07-02 12:03 ` Peter Zijlstra
2018-07-03 2:10 ` 王贇
2018-07-03 5:42 ` [PATCH] tg: show " 王贇
2018-07-04 3:27 ` [PATCH v2] " 王贇
2018-07-09 9:12 ` 王贇
2018-07-17 3:28 ` 王贇
2018-07-23 9:31 ` Peter Zijlstra [this message]
2018-07-23 12:32 ` 王贇
2018-07-23 13:31 ` [PATCH v3] " 王贇
2018-07-25 14:23 ` [tip:sched/core] sched/debug: Show the sum wait time of a " tip-bot for Yun Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723093121.GA2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=yun.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome