From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF83ECDFB8 for ; Mon, 23 Jul 2018 09:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8FD620875 for ; Mon, 23 Jul 2018 09:41:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8FD620875 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388227AbeGWKla convert rfc822-to-8bit (ORCPT ); Mon, 23 Jul 2018 06:41:30 -0400 Received: from mail.bootlin.com ([62.4.15.54]:46157 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388175AbeGWKl3 (ORCPT ); Mon, 23 Jul 2018 06:41:29 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id A9DF820756; Mon, 23 Jul 2018 11:41:07 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 61EA3206A6; Mon, 23 Jul 2018 11:41:07 +0200 (CEST) Date: Mon, 23 Jul 2018 11:41:07 +0200 From: Boris Brezillon To: Arnd Bergmann Cc: Randy Dunlap , Anders Roxell , Miquel Raynal , Linux Kernel Mailing List , Rob Herring , DTML Subject: Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency Message-ID: <20180723114107.664164d2@bbrezillon> In-Reply-To: References: <20180721200049.7553-1-anders.roxell@linaro.org> <20180722082939.2de739f1@bbrezillon> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Jul 2018 11:34:43 +0200 Arnd Bergmann wrote: > On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon > wrote: > > +Arnd, Rob and the DT ML. > > > > On Sat, 21 Jul 2018 14:53:47 -0700 > > Randy Dunlap wrote: > > > >> On 07/21/2018 01:00 PM, Anders Roxell wrote: > >> > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this > >> > error: > >> > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’: > >> > drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of > >> > function ‘of_read_number’; did you mean ‘down_read_nested’? > >> > [-Werror=implicit-function-declaration] > >> > bank = of_read_number(prop, 1); > >> > ^~~~~~~~~~~~~~ > >> > down_read_nested > > > > Looks like of.h defines stubs so that people can compile-test without > > CONFIG_OF selected. Maybe we should move of_read_number() and > > of_read_ulong() out of the #ifdef CONFIG_OF section. > > That seems fine, though the added dependency seems appropriate > here as well. of_read_number() is rarely used, and for the most part in > powerpc specific code that is guaranteed to have CONFIG_OF enabled, > so it's not that likely to cause many more problems. Ok, then I'll let Miquel apply Anders' patch to the NAND tree. Thanks for your feedback. Boris