From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
pombredanne@nexb.com, kstewart@linuxfoundation.org,
tglx@linutronix.de, John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 01/15] staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style
Date: Mon, 23 Jul 2018 21:50:17 +0100 [thread overview]
Message-ID: <20180723205031.19816-2-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180723205031.19816-1-johnfwhitmore@gmail.com>
The typedef of QOS_MODE as a u32 is contrary to coding standard and fails
the checkpatch tests for defining new types in code. Definitions of type
QOS_MODE have simply been replaced with a u32 type.
This is a coding style change which should not impact runtime execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
index 96e9621e9887..45ba96a13b13 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
@@ -16,7 +16,6 @@
// QOS_HCCA = 4,
//}QOS_MODE,*PQOS_MODE;
//
-typedef u32 QOS_MODE, *PQOS_MODE;
#define QOS_DISABLE 0
#define QOS_WMM 1
#define QOS_WMMSA 2
@@ -454,8 +453,8 @@ typedef struct _STA_QOS {
u8 *WMMIE;
// Part 1. Self QoS Mode.
- QOS_MODE QosCapability; //QoS Capability, 2006-06-14 Isaiah
- QOS_MODE CurrentQosMode;
+ u32 QosCapability; // QOS_MODE QoS Capability, 2006-06-14 Isaiah
+ u32 CurrentQosMode; // QOS_MODE
// For WMM Power Save Mode :
// ACs are trigger/delivery enabled or legacy power save enabled. 2006-06-13 Isaiah
@@ -502,7 +501,7 @@ typedef struct _STA_QOS {
// Ref: BssDscr in 8185 code. [def. in BssDscr.h]
//
typedef struct _BSS_QOS {
- QOS_MODE bdQoSMode;
+ u32 bdQoSMode; // QOS_MODE
u8 bdWMMIEBuf[MAX_WMMELE_LENGTH];
u8 *bdWMMIE;
--
2.18.0
next prev parent reply other threads:[~2018-07-23 20:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 20:50 [PATCH 00/15] Removal of usused definitions " John Whitmore
2018-07-23 20:50 ` John Whitmore [this message]
2018-07-23 20:50 ` [PATCH 02/15] staging:rtl8192u: Remove unused enumerated type ACK_POLICY " John Whitmore
2018-07-23 20:50 ` [PATCH 03/15] staging:rtl8192u: Remove unused QOS definitions " John Whitmore
2018-07-23 20:50 ` [PATCH 04/15] staging:rtl8192u: Removed unused structure BSS_QOS " John Whitmore
2018-07-23 20:50 ` [PATCH 05/15] staging:rtl8192u: Remove unused structure STA_QOS " John Whitmore
2018-07-23 20:50 ` [PATCH 06/15] staging:rtl8192u: Remove unused structure QOS_CTRL_FIELD " John Whitmore
2018-07-23 20:50 ` [PATCH 07/15] staging:rtl8192u: Remove unused union QOS_INFO_FIELD " John Whitmore
2018-07-23 20:50 ` [PATCH 08/15] staging:rtl8192u: Remove the unused AC_CODING definitions " John Whitmore
2018-07-23 20:50 ` [PATCH 09/15] staging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE " John Whitmore
2018-07-23 20:50 ` [PATCH 10/15] staging:rtl8192u: Remove unused structure QOS_TSTREAM " John Whitmore
2018-07-23 20:50 ` [PATCH 11/15] staging:rtl8192u: Remove unused structure WMM_TSPEC " John Whitmore
2018-07-23 20:50 ` [PATCH 12/15] staging:rtl8192u: Remove unused enumerated type ACM_METHOD " John Whitmore
2018-07-23 20:50 ` [PATCH 13/15] staging:rtl8192u: Remove unused structure ACM " John Whitmore
2018-07-23 20:50 ` [PATCH 14/15] staging:rtl8192u: Remove unused AC_UAPSD definitions " John Whitmore
2018-07-23 20:50 ` [PATCH 15/15] staging:rtl8192u: Remove unused definition of sQoSCtlLng " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723205031.19816-2-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome