From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAC0C6778A for ; Tue, 24 Jul 2018 14:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE5F620852 for ; Tue, 24 Jul 2018 14:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE5F620852 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388559AbeGXPsv (ORCPT ); Tue, 24 Jul 2018 11:48:51 -0400 Received: from mail.bootlin.com ([62.4.15.54]:36143 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388430AbeGXPsv (ORCPT ); Tue, 24 Jul 2018 11:48:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 8343220730; Tue, 24 Jul 2018 16:42:01 +0200 (CEST) Received: from localhost (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 5075E206A6; Tue, 24 Jul 2018 16:41:51 +0200 (CEST) Date: Tue, 24 Jul 2018 16:41:51 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Icenowy Zheng , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH 3/3] arm64: allwinner: dts: h6: add Wi-Fi support for Pine H64 model A/B Message-ID: <20180724144151.myyg7slocsfjjsfi@flea> References: <20180724011551.49603-1-icenowy@aosc.io> <20180724011551.49603-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fhazolum5rz6spmk" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fhazolum5rz6spmk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 24, 2018 at 10:37:51AM +0800, Chen-Yu Tsai wrote: > On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng wrote: > > > > > > =E4=BA=8E 2018=E5=B9=B47=E6=9C=8824=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D= =8810:26:02, Chen-Yu Tsai =E5=86=99=E5=88=B0: > >>On Tue, Jul 24, 2018 at 10:23 AM, Icenowy Zheng > >>wrote: > >>> > >>> > >>> =E4=BA=8E 2018=E5=B9=B47=E6=9C=8824=E6=97=A5 GMT+08:00 =E4=B8=8A=E5= =8D=8810:21:59, Chen-Yu Tsai =E5=86=99=E5=88=B0: > >>>>On Tue, Jul 24, 2018 at 9:15 AM, Icenowy Zheng > >>wrote: > >>>>> The Pine H64 model A has a Wi-Fi module connector and the model B > >>has > >>>>an > >>>>> on-board RTL8723BS Wi-Fi module. > >>>>> > >>>>> Add support for them. For model A, as it's not defaultly present, > >>>>keep > >>>>> it disabled now. > >>>> > >>>>Nope. Pine64 actually has two WiFi/BT modules. And they require > >>>>different > >>>>device tree snippets for both the WiFi and BT side. This is better > >>>>resolved > >>>>with device tree overlays. > >>>> > >>>>I have both, though I've yet found time to work on them. > >>> > >>> I have also both. > >>> > >>> The skeleton here can get the Wi-Fi of both to work. > >> > >>Cool. Then I can put away my RTL module for now. :) > > > > P.S. SDIO is auto detectable, and for BCM chips, the OOB interrupt > > is only a bonus function and it can fall back to standard in-band > > interrupt (which doesn't need special binding, and is currently > > used by mainline r8723bs driver.) >=20 > Correct. With BT you'll have serdev device nodes with different > compatibles. Then you'll have to resort to overlays, and you'd probably > end up adding WiFi OOB interrupt bits as well. >=20 > So the question remaining is: should we enable the MMC part, along > with power sequencing and regulator supplies, by default? Thinking > more about it, I'm actually OK with it. The board connectors are > clearly marked as being for a WiFi+BT module. The whole space on > the board is surrounded by a box in silkscreen. Sorry for the > initial nack. >=20 > Maxime, any thoughts? If there's a need for an overlay anyway, there's no real reason to enable it by default, especially if not everything is there. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --fhazolum5rz6spmk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAltXOq4ACgkQ0rTAlCFN r3SIrg//XVODv2+vLg3T9F4oCqaEy9wgJHKNryVNxe9yQ/EkIL5GjZkPvRsvaTz5 AvW+PtUP03WcxjarG3B9183vTgeWczvXdaKJE6yabbZ5O/byYKAnD3DynvDNwm3G 1Le/NlM8ugTz7fRJ1pF0ermWtm/MkRD6Bg1+Uqhe6GaITAjkgMLw5WeDQ3x2S1VS DXk/KuO4CnJWXmMOil6/befh4xml0QeKiIpGdWyCtUBSPqlHONKNWJVxpB858Wk7 Rh0r8bw7F6lnOA0QYkjANJKfWgerw3+WtmbPxssXQpooD33fT2hlUIII+OjL0l1e uAO0yUL8GtM8qxgrgZnkfLCuvcImbse4tvhAvqf/J2GjjLYCMcpfbwntyv9Qbkhn vIJcV8DtOa7zQAK6Z2i3xiUYWjJD8UZNOQ3ImLr/StmCYL6D3g4Ys37L6Gex2mhY tsGC+/YjM3oiENlYF1bVXNFUEy4j6JVQxWrIuMGIgoVSjXRknbKm1554OjwqvALy BgfFbpJsqORqq1PyW2uKTUPY6gaBUaEwb785WOcJuE88r9uR6KFWT8JrZi9pp4H0 eLJocGgZKZGQRUfxRylNBvHKPGNo+GVdSH7cxgzQS/mGoj1+q5gSV/W+MEJIq9lm gtckHs0j1LXXsQR2/KH/s312EIWSVfni9pXzxuL4NpUexLdh4dw= =ytpg -----END PGP SIGNATURE----- --fhazolum5rz6spmk--