From: Jon Mason <jdmason@kudzu.us>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vxge: Remove unnecessary include of <linux/pci_hotplug.h>
Date: Tue, 24 Jul 2018 11:45:27 -0400 [thread overview]
Message-ID: <20180724154526.GB5871@kudzu.us> (raw)
In-Reply-To: <153237958637.172194.6734539971240967379.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Jul 23, 2018 at 03:59:46PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Not sure you need my ack for something so trivial, but here it is
Acked-by: Jon Mason <jdmason@kudzu.us>
> ---
> drivers/net/ethernet/neterion/vxge/vxge-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> index 358ed6118881..a2c0a93ca8b6 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> @@ -14,7 +14,6 @@
> #include <linux/vmalloc.h>
> #include <linux/etherdevice.h>
> #include <linux/pci.h>
> -#include <linux/pci_hotplug.h>
> #include <linux/slab.h>
>
> #include "vxge-traffic.h"
>
next prev parent reply other threads:[~2018-07-24 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 20:59 Bjorn Helgaas
2018-07-24 15:45 ` Jon Mason [this message]
2018-07-25 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724154526.GB5871@kudzu.us \
--to=jdmason@kudzu.us \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®