From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7415AC6778A for ; Tue, 24 Jul 2018 14:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EF5D2064D for ; Tue, 24 Jul 2018 14:55:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=bidouilliste.com header.i=@bidouilliste.com header.b="nUYoz7sj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EF5D2064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bidouilliste.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388638AbeGXQB4 (ORCPT ); Tue, 24 Jul 2018 12:01:56 -0400 Received: from mail.blih.net ([212.83.177.182]:57718 "EHLO mail.blih.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388570AbeGXQBz (ORCPT ); Tue, 24 Jul 2018 12:01:55 -0400 Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id ba919e84; Tue, 24 Jul 2018 16:55:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=B0EL9q42UBKS3BSlMM55T/VVShg=; b=nUYoz7sjb4ErwmUxucVI8qU9OQ3x Ovfw7YuZm+TcLoLkPeFl5Ap0bQmAei8YrfkR03GIwLAWixNibdB7GH2fE7unghUZ E7F5T4hv5wI1AFUw2qWy3UpO5NEpob8DbIPR7Hh71UV9VjAjnwiZA+JfGHhzkzbP jdVVanjmzxpzTS4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=L6LygtA7Z2wpA5x+3Kbxlb1H0pzoktni/UkJST3KbOmTdb1Lr6/EzFvF 4mk1WIe3pbIs+l/we7fufUL+X36f3T3fLdiUytN0AJ/qMs2rOYzZlPpAf3zwtELm +DPHxHdSE6tX7ZzEzuvYtFFhzBYsFS78B9Dj0BLWb/yrAiUc6Ic= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id f97f48cf TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Tue, 24 Jul 2018 16:55:02 +0200 (CEST) Date: Tue, 24 Jul 2018 16:55:01 +0200 From: Emmanuel Vadot To: Maxime Ripard Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Emmanuel Vadot , wens@csie.org, robh+dt@kernel.org, srinivas.kandagatla@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5 Message-Id: <20180724165501.d8f01bf20c7cc43e7ed7fc62@bidouilliste.com> In-Reply-To: <20180724144218.jdvgrcqkz2kmohqx@flea> References: <20180724101522.68165-1-manu@freebsd.org> <20180724101522.68165-5-manu@freebsd.org> <20180724130004.ynaiabshexrrbvo4@flea> <20180724153432.e398bddfe63e51e8dcebfc46@bidouilliste.com> <20180724144218.jdvgrcqkz2kmohqx@flea> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jul 2018 16:42:18 +0200 Maxime Ripard wrote: > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote: > > On Tue, 24 Jul 2018 15:00:04 +0200 > > Maxime Ripard wrote: > > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote: > > > > The SID controller on H5 look the same as the one present in the A64. > > > > But in case we find some difference one day at a compatible string > > > > of it's own and a fallback to the A64 one. > > > > > > > > Signed-off-by: Emmanuel Vadot > > > > --- > > > > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > index 62d646baac3c..28183bf77164 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > > > > @@ -129,3 +129,8 @@ > > > > ; > > > > compatible = "allwinner,sun50i-h5-pinctrl"; > > > > }; > > > > + > > > > +&sid { > > > > + compatible = "allwinner,sun50i-h5-sid", > > > > + "allwinner,sun50i-a64-sid"; > > > > +}; > > > > > > This is still a bit pointless, please remove the common node. > > > > You mean directly declare sid controller in the SoC dtsi and not > > have a common node in sunxi-h3-h5.dtsi ? > > Yep > > -- > Maxime Ripard, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com The reason I've put it in the common file is because I'll send patches for the nvmem-cells needed for thermal, and those are common between the two. Other nvmem-cells are also common (like the chipid and probably other). -- Emmanuel Vadot