From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1050BC67790 for ; Wed, 25 Jul 2018 20:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF4E520671 for ; Wed, 25 Jul 2018 20:42:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4E520671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731435AbeGYVzg (ORCPT ); Wed, 25 Jul 2018 17:55:36 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55696 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730305AbeGYVzg (ORCPT ); Wed, 25 Jul 2018 17:55:36 -0400 Received: from localhost (unknown [172.58.43.97]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9FD3A1231CA94; Wed, 25 Jul 2018 13:42:13 -0700 (PDT) Date: Wed, 25 Jul 2018 13:42:11 -0700 (PDT) Message-Id: <20180725.134211.849330522483481967.davem@davemloft.net> To: krzk@kernel.org Cc: pantelis.antoniou@gmail.com, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ebiggers3@gmail.com Subject: Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation From: David Miller In-Reply-To: <20180723162020.6221-1-krzk@kernel.org> References: <20180723162020.6221-1-krzk@kernel.org> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jul 2018 13:42:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Date: Mon, 23 Jul 2018 18:20:20 +0200 > Use generic kernel CRC32 implementation because it: > 1. Should be faster (uses lookup tables), > 2. Removes duplicated CRC generation code, > 3. Uses well-proven algorithm instead of coding it one more time. > > Suggested-by: Eric Biggers > Signed-off-by: Krzysztof Kozlowski Applied.