mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Georgios Tsotsos <tsotsos@gmail.com>
Cc: devel@driverdev.osuosl.org, James Hogan <jhogan@kernel.org>,
	linux-kernel@vger.kernel.org,
	Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 0/4] Staging: octeon-usb: Fixes and Coding style applied.
Date: Wed, 25 Jul 2018 09:57:29 +0200	[thread overview]
Message-ID: <20180725075729.GA22990@kroah.com> (raw)
In-Reply-To: <20180724223853.10198-1-tsotsos@gmail.com>

On Wed, Jul 25, 2018 at 01:38:49AM +0300, Georgios Tsotsos wrote:
> Hello, 
> 
> Previously patches were sent with wrong cover format, please ignore.
> 
> I am sending four patches which trying to resolve TODO list requirements 
> no 45 about octeon-usb. 
> There are SPDX licence additions on c and header files. 
> Checkpatch warnings are resolved,also a notice about CVMX_WAIT_FOR_FIELD32 macro.
> It could improve readability and maintenance of this module if function
> cvmx_usb_poll_channel() break down (and probably some others too)

My same comments hold true for the "no changelog" patches :(

thanks,

greg k-h

      parent reply	other threads:[~2018-07-25  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 22:38 Georgios Tsotsos
2018-07-24 22:38 ` [PATCH 1/4] Staging: octeon-usb: Adds SPDX License Identifier Georgios Tsotsos
2018-07-24 22:38 ` [PATCH 2/4] Staging: octeon-usb: Applying coding style for column width Georgios Tsotsos
2018-07-24 22:38 ` [PATCH 3/4] Staging: octeon-usb: Change coding style for CVMX_WAIT_FOR_FIELD32 marco Georgios Tsotsos
2018-07-24 22:38 ` [PATCH 4/4] Staging: octeon-usb: Adds SPDX License Identifier for header file Georgios Tsotsos
2018-07-25  7:57 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725075729.GA22990@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=devel@driverdev.osuosl.org \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tsotsos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome