From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AF7C6778F for ; Wed, 25 Jul 2018 10:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79D9720843 for ; Wed, 25 Jul 2018 10:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79D9720843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728765AbeGYL3F (ORCPT ); Wed, 25 Jul 2018 07:29:05 -0400 Received: from mail.bootlin.com ([62.4.15.54]:58976 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728708AbeGYL3E (ORCPT ); Wed, 25 Jul 2018 07:29:04 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id B238F20798; Wed, 25 Jul 2018 12:18:01 +0200 (CEST) Received: from localhost (unknown [80.255.6.130]) by mail.bootlin.com (Postfix) with ESMTPSA id 6F3782072C; Wed, 25 Jul 2018 12:17:51 +0200 (CEST) Date: Wed, 25 Jul 2018 12:17:51 +0200 From: Alexandre Belloni To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg , Nicolas Ferre , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: at91: remove unused duplicated filechk_offsets Message-ID: <20180725101751.GB3539@piout.net> References: <1532495771-10255-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532495771-10255-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/2018 14:16:10+0900, Masahiro Yamada wrote: > The filechk_offsets in arch/arm/mach-at91/Makefile is never > used because it is always overridden by the equivalent one in > scripts/Makefile.lib > > Signed-off-by: Masahiro Yamada Acked-by: Alexandre Belloni > --- > > I will queue this to my kbuild tree. > > > arch/arm/mach-at91/Makefile | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile > index 4ea93c9..7415f18 100644 > --- a/arch/arm/mach-at91/Makefile > +++ b/arch/arm/mach-at91/Makefile > @@ -19,31 +19,6 @@ ifeq ($(CONFIG_PM_DEBUG),y) > CFLAGS_pm.o += -DDEBUG > endif > > -# Default sed regexp - multiline due to syntax constraints > -define sed-y > - "/^->/{s:->#\(.*\):/* \1 */:; \ > - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \ > - s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \ > - s:->::; p;}" > -endef > - > -# Use filechk to avoid rebuilds when a header changes, but the resulting file > -# does not > -define filechk_offsets > - (set -e; \ > - echo "#ifndef $2"; \ > - echo "#define $2"; \ > - echo "/*"; \ > - echo " * DO NOT MODIFY."; \ > - echo " *"; \ > - echo " * This file was generated by Kbuild"; \ > - echo " */"; \ > - echo ""; \ > - sed -ne $(sed-y); \ > - echo ""; \ > - echo "#endif" ) > -endef > - > arch/arm/mach-at91/pm_data-offsets.s: arch/arm/mach-at91/pm_data-offsets.c > $(call if_changed_dep,cc_s_c) > > -- > 2.7.4 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com