From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA44CC6778F for ; Wed, 25 Jul 2018 13:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F46620852 for ; Wed, 25 Jul 2018 13:51:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F46620852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729130AbeGYPDh (ORCPT ); Wed, 25 Jul 2018 11:03:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:52652 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728902AbeGYPDh (ORCPT ); Wed, 25 Jul 2018 11:03:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 38A46AFBC; Wed, 25 Jul 2018 13:51:49 +0000 (UTC) Date: Wed, 25 Jul 2018 15:51:47 +0200 From: Michal Hocko To: David Hildenbrand Cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Baoquan He , Dave Young , Greg Kroah-Hartman , Hari Bathini , Huang Ying , "Kirill A. Shutemov" , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Matthew Wilcox , Miles Chen , Pavel Tatashin , Petr Tesarik Subject: Re: [PATCH v1 0/2] mm/kdump: exclude reserved pages in dumps Message-ID: <20180725135147.GN28386@dhcp22.suse.cz> References: <20180720123422.10127-1-david@redhat.com> <9f46f0ed-e34c-73be-60ca-c892fb19ed08@suse.cz> <20180723123043.GD31229@dhcp22.suse.cz> <8daae80c-871e-49b6-1cf1-1f0886d3935d@redhat.com> <20180724072536.GB28386@dhcp22.suse.cz> <8eb22489-fa6b-9825-bc63-07867a40d59b@redhat.com> <20180724131343.GK28386@dhcp22.suse.cz> <20180724133530.GN28386@dhcp22.suse.cz> <6c753cae-f8b6-5563-e5ba-7c1fefdeb74e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c753cae-f8b6-5563-e5ba-7c1fefdeb74e@redhat.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24-07-18 16:13:09, David Hildenbrand wrote: [...] > So I see right now: > > - Pg_reserved + e.g. new page type (or some other unique identifier in > combination with Pg_reserved) > -> Avoid reads of pages we know are offline > - extend is_ram_page() > -> Fake zero memory for pages we know are offline > > Or even both (avoid reading and don't crash the kernel if it is being done). I really fail to see how that can work without kernel being aware of PageOffline. What will/should happen if you run an old kdump tool on a kernel with this partially offline memory? -- Michal Hocko SUSE Labs