From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D867C28CF6 for ; Thu, 26 Jul 2018 08:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45BF620673 for ; Thu, 26 Jul 2018 08:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="dhHI/l4z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45BF620673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729212AbeGZJmO (ORCPT ); Thu, 26 Jul 2018 05:42:14 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:53988 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbeGZJmO (ORCPT ); Thu, 26 Jul 2018 05:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AFX+MXs8zyhQa0Fta/QCyt2naUj5o5TK+Pk7DYHG57I=; b=dhHI/l4zEUn8AMnnW2oTn1BfG kJlP11ZpAyBshLHi0+m7InqmUkc+xmCDDDCMFws2kOsXmCqSJBO12PJrGNdI0dZ/frhKTxFlzN+N/ nh59yHhTEaPRSd95GmICv094o2tt5rOpOVQSk88dgk4yYaoXRxNu7eysqrlvTcMJIvOok=; Received: from n2100.armlinux.org.uk ([fd8f:7570:feb6:1:214:fdff:fe10:4f86]:50556) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1fibbO-0002my-58; Thu, 26 Jul 2018 09:26:26 +0100 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1fibbL-0007ja-Fn; Thu, 26 Jul 2018 09:26:23 +0100 Date: Thu, 26 Jul 2018 09:26:21 +0100 From: Russell King - ARM Linux To: bgoswami@codeaurora.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org Subject: Re: [PATCH][RESEND 2] component: enhance handling of devres group for master Message-ID: <20180726082621.GW17271@n2100.armlinux.org.uk> References: <1532585188-7831-1-git-send-email-bgoswami@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532585188-7831-1-git-send-email-bgoswami@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 11:06:28PM -0700, bgoswami@codeaurora.org wrote: > From: Banajit Goswami > > The devres group opened for a master is left open-ended (without > devres_group_close) even after bind() is complete. Similarly, while > releasing the devres resources for master, the most recently opened > devres group is selected, and released without identifying the > targeted group. As the devres group opened before master bind was > never closed, there may have unintended consequences of releasing > devres resources that were allocated after master bind() function > was complete. ... as intended, because this layers on top of the driver model. You are aware that the driver model leaves its implicit group open as well? I think you need to explain why you need this - what is the problem scenario that you are encountering. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up