From: Andrew Morton <akpm@linux-foundation.org>
To: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
Cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get_maintainer: Allow usage outside of kernel tree
Date: Thu, 26 Jul 2018 15:39:46 -0700 [thread overview]
Message-ID: <20180726153946.3d81bf367cef7fe241bb3741@linux-foundation.org> (raw)
In-Reply-To: <04452ac6-1575-f612-72c6-6ea88e70a9d5@arm.com>
On Tue, 26 Jun 2018 11:07:03 +0100 Antonio Nino Diaz <antonio.ninodiaz@arm.com> wrote:
> Add option '--no-tree' to get_maintainer.pl script to allow using this
> script in projects that aren't the Linux kernel if they use the same
> format for their MAINTAINERS file. This command is also available in
> checkpatch.pl, for example.
>
Seems OK to me?
Please note that your email client is converting tabs to spaces.
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -48,6 +48,7 @@ my $output_roles = 0;
> my $output_rolestats = 1;
> my $output_section_maxlen = 50;
> my $scm = 0;
> +my $tree = 1;
> my $web = 0;
> my $subsystem = 0;
> my $status = 0;
> @@ -255,6 +256,7 @@ if (!GetOptions(
> 'subsystem!' => \$subsystem,
> 'status!' => \$status,
> 'scm!' => \$scm,
> + 'tree!' => \$tree,
> 'web!' => \$web,
> 'letters=s' => \$letters,
> 'pattern-depth=i' => \$pattern_depth,
> @@ -319,7 +321,7 @@ if ($email &&
> die "$P: Please select at least 1 email option\n";
> }
>
> -if (!top_of_kernel_tree($lk_path)) {
> +if ($tree && !top_of_kernel_tree($lk_path)) {
> die "$P: The current directory does not appear to be "
> . "a linux kernel source tree.\n";
> }
> @@ -1031,13 +1033,14 @@ Other options:
> --sections => print all of the subsystem sections with pattern matches
> --letters => print all matching 'letter' types from all matching sections
> --mailmap => use .mailmap file (default: $email_use_mailmap)
> + --no-tree => run without a kernel tree
> --self-test => show potential issues with MAINTAINERS file content
> --version => show version
> --help => show this help information
>
> Default options:
> - [--email --nogit --git-fallback --m --r --n --l --multiline --pattern-depth=0
> - --remove-duplicates --rolestats]
> + [--email --tree --nogit --git-fallback --m --r --n --l --multiline
> + --pattern-depth=0 --remove-duplicates --rolestats]
>
> Notes:
> Using "-f directory" may give unexpected results:
next prev parent reply other threads:[~2018-07-26 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 10:07 Antonio Nino Diaz
2018-07-26 22:39 ` Andrew Morton [this message]
2018-07-27 0:56 ` Joe Perches
2018-07-30 12:20 ` Antonio Nino Diaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726153946.3d81bf367cef7fe241bb3741@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=antonio.ninodiaz@arm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®