From: David Miller <davem@davemloft.net>
To: baijiaju1990@gmail.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
linyunsheng@huawei.com, joe@perches.com, pombredanne@nexb.com,
bianpan2016@163.com, shenjian15@huawei.com,
keescook@chromium.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hisilicon: hns: Replace mdelay() with msleep()
Date: Fri, 27 Jul 2018 14:12:16 -0700 (PDT) [thread overview]
Message-ID: <20180727.141216.2218815863913834329.davem@davemloft.net> (raw)
In-Reply-To: <20180727080141.3079-1-baijiaju1990@gmail.com>
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 27 Jul 2018 16:01:41 +0800
> hns_ppe_common_init_hw() and hns_xgmac_init() are never
> called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied.
prev parent reply other threads:[~2018-07-27 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 8:01 Jia-Ju Bai
2018-07-27 21:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727.141216.2218815863913834329.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baijiaju1990@gmail.com \
--cc=bianpan2016@163.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®