From: Peter Zijlstra <peterz@infradead.org>
To: Cheng Lin <cheng.lin130@zte.com.cn>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn,
tan.hu@zte.com.cn.cn
Subject: Re: [PATCH v2] sched/numa: do not balance tasks onto isolated cpus
Date: Fri, 27 Jul 2018 09:48:51 +0200 [thread overview]
Message-ID: <20180727074851.GY2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1532593148-106266-1-git-send-email-cheng.lin130@zte.com.cn>
On Thu, Jul 26, 2018 at 04:19:08PM +0800, Cheng Lin wrote:
> - if (!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + if ((!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + || !housekeeping_test_cpu(arg.dst_cpu, HK_FLAG_DOMAIN))
> goto out;
You did not read the comment I provided last time. Using isolcpus (and
thus it's renamed houskeeping thing) is the wrong thing to do. Load
balancing should be limited to it's root domain.
prev parent reply other threads:[~2018-07-27 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 8:19 Cheng Lin
2018-07-27 7:48 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727074851.GY2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cheng.lin130@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tan.hu@zte.com.cn.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®