From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chao Yu <chao@kernel.org>, Chao Yu <yuchao0@huawei.com>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning
Date: Fri, 27 Jul 2018 19:18:49 +0900 [thread overview]
Message-ID: <20180727101849.GG16155@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <CAK8P3a0DTCOtLLKRx6Z41fnweJyB8+J1zjEcpf9oQvMrj82-DA@mail.gmail.com>
On 07/25, Arnd Bergmann wrote:
> On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu <chao@kernel.org> wrote:
> > On 2018/7/24 17:34, Arnd Bergmann wrote:
> >> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu
> >> causes a warning:
> >>
> >> fs/f2fs/inode.c: In function 'sanity_check_inode':
> >> fs/f2fs/inode.c:247:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Werror=format=]
> >>
> >> The correct format string is %zu.
> >>
> >> Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I noticed the issue, thank you for fixing it, but original buggy patch has not
> > been upstreamed yet, how about merging this fix into origial patch, if you don't
> > mind?
>
> Yes, please do that.
Squashed.
Thank you.
>
> Arnd
prev parent reply other threads:[~2018-07-27 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 9:34 Arnd Bergmann
2018-07-25 15:21 ` [f2fs-dev] " Chao Yu
2018-07-25 19:37 ` Arnd Bergmann
2018-07-27 10:18 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727101849.GG16155@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=arnd@arndb.de \
--cc=chao@kernel.org \
--cc=ebiggers@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®