Re: [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit

[Masami Hiramatsu <mhiramat@kernel.org>]

On Thu, 26 Jul 2018 19:29:43 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 26 Jul 2018 14:53:55 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > From: Francis Deslauriers <francis.deslauriers@efficios.com>
> > 
> > Move selftest function to its own compile unit so it can be compiled
> > with the ftrace cflags (CC_FLAGS_FTRACE) allowing it to be probed
> > during the ftrace startup tests.
> > 
> > Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Hi Masami,
> 
> Actually, since you are sending this as part of your patch queue, you
> need to add your Signed-off-by here and not Acked-by. That means it has
> gone through you.

Ah, I see.

> 
> I've applied the first patch already, just resend this one, where you
> add you Signed-off-by instead of Acked-by.

OK, I'll do that soon.

Thanks!

> 
> Thanks!
> 
> -- Steve
> 
> 
> > ---
> >  kernel/trace/Makefile                |    5 +++++
> >  kernel/trace/trace_kprobe.c          |   12 +-----------
> >  kernel/trace/trace_kprobe_selftest.c |   10 ++++++++++
> >  kernel/trace/trace_kprobe_selftest.h |    7 +++++++
> >  4 files changed, 23 insertions(+), 11 deletions(-)
> >  create mode 100644 kernel/trace/trace_kprobe_selftest.c
> >  create mode 100644 kernel/trace/trace_kprobe_selftest.h
> > 


-- 
Masami Hiramatsu <mhiramat@kernel.org>