From: Tomas Janousek <tomi@nomi.cz>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: fix NPE when resuming SCSI devices using blk-mq
Date: Sun, 29 Jul 2018 11:41:31 +0200 [thread overview]
Message-ID: <20180729094131.4kwuukzgfgtisgya@notes.lisk.in> (raw)
In-Reply-To: <CACVXFVPoO7kcEnUVmqGVWDgiTVYup2sD9puBZ8FzY+mDaMp-bQ@mail.gmail.com>
Hi,
On Fri, Jul 13, 2018 at 09:41:41PM +0800, Ming Lei wrote:
> Now runtime PM is disabled for blk-mq/scsi_mq, not sure how this issue is
> triggered on your machine.
While Patrick did miss the following patch:
* 765e40b675a9 ("block: disable runtime-pm for blk-mq"; July 2017).
there is at least one other way to trigger it -- enable laptop-mode-tools
or tlp which enable runtime-pm for all devices.
The "disable runtime-pm for blk-mq" only disables it _by_default_, but doesn't
prevent it from being enabled again from user-space, which it is unless one
manually blacklists sd devices from runtime-pm enablement. It's bitten a few
people already: https://github.com/rickysarraf/laptop-mode-tools/issues/123
(I found this thread because I'm also getting the NULL pointer dereference at
00000000000001a8 on resume from suspend.)
--
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/
next prev parent reply other threads:[~2018-07-29 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 13:29 Patrick Steinhardt
2018-07-13 13:41 ` Ming Lei
2018-07-16 15:11 ` Patrick Steinhardt
2018-07-29 9:41 ` Tomas Janousek [this message]
2018-07-30 7:59 ` Patrick Steinhardt
2018-07-30 11:50 ` Ming Lei
2018-07-30 15:00 ` Tomas Janousek
2018-07-25 18:13 ` Bart Van Assche
2018-07-26 8:38 ` Patrick Steinhardt
2018-07-26 13:51 ` Bart Van Assche
2018-07-27 12:35 ` Patrick Steinhardt
2018-07-27 15:03 ` Bart Van Assche
2018-07-28 18:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729094131.4kwuukzgfgtisgya@notes.lisk.in \
--to=tomi@nomi.cz \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ps@pks.im \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®