From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3C016256E1 for ; Mon, 30 Jul 2018 16:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64E7820870 for ; Mon, 30 Jul 2018 16:31:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I7tSbfT0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E7820870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732009AbeG3SHn (ORCPT ); Mon, 30 Jul 2018 14:07:43 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36832 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbeG3SHn (ORCPT ); Mon, 30 Jul 2018 14:07:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L+VqRxL2623I1QB59rLII0627VGk5uURaCYSQZKcFfY=; b=I7tSbfT01p+MSuqgTWohQAiMS T0nysCIZJ4mYH6Wji8orylE/hWf0y+pOt/msQppAofZw0k9MaQWvBq9jQeYbhR7UljNFwAm3PmvRH Ky7C16Zij+V5yhfPmEPmROkwE1JKX4hjknVPVu6HUF2B3aqfVzz+YjA1u/tAVEI1N+W8fZM7itzZN 1dOOVFiG871hBFyvYqPvOhJ5GafGXEj6rGXJePqe8LzDtI36Hy1jTt9+03wRhZfZNK66rHBnmdpL6 sBg8lIQGnJYot9gNwuDzW+iJw1O4PRTIFYx8NeoGGOoCVKiDorjjNtTXIHVz8eiXklN3p675x/IA5 OaA3HCkUg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkB5P-0005vq-Va; Mon, 30 Jul 2018 16:31:55 +0000 Date: Mon, 30 Jul 2018 09:31:55 -0700 From: Christoph Hellwig To: Christian Brauner Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, tkjos@android.com, maco@android.com, rlove@google.com, ben@decadent.org.uk Subject: Re: [PATCH 1/4] file: export __alloc_fd() Message-ID: <20180730163155.GA27761@infradead.org> References: <20180730143710.14413-1-christian@brauner.io> <20180730143710.14413-2-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180730143710.14413-2-christian@brauner.io> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 04:37:07PM +0200, Christian Brauner wrote: > The Android binder driver will be turned into a module. Since it uses > __alloc_fd() we need to export this function. Err, hell no. It should be using an anon fd probably.